From: Jesper Dangaard Brouer <brouer@redhat.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
brouer@redhat.com
Subject: Re: [PATCH net-next 1/2] xdp: Always use a devmap for XDP_REDIRECT to a device
Date: Thu, 21 Feb 2019 16:19:50 +0100 [thread overview]
Message-ID: <20190221161950.1938cc8c@carbon> (raw)
In-Reply-To: <155075021399.13610.12521373406832889226.stgit@alrua-x1>
You forgot at cover letter describing why we are doing this...
even-though is should be obvious from the performance results ;-)
On Thu, 21 Feb 2019 12:56:54 +0100 Toke Høiland-Jørgensen <toke@redhat.com> wrote:
> Before patch:
> xdp_redirect: 5426035 pkt/s
> xdp_redirect_map: 8412754 pkt/s
>
> After patch:
> xdp_redirect: 8314702 pkt/s
> xdp_redirect_map: 8411854 pkt/s
>
> This corresponds to a 53% increase in xdp_redirect performance, or a
> reduction in per-packet processing time by 64 nanoseconds.
(1/5426035-1/8314702)*10^9 = 64.0277 almost exactly 64 nanosec
(1/8412754-1/8411854)*10^9 = -0.012 => no regression for xdp_redirect_map
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-02-21 15:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 11:56 [PATCH net-next 1/2] xdp: Always use a devmap for XDP_REDIRECT to a device Toke Høiland-Jørgensen
2019-02-21 11:56 ` [PATCH net-next 2/2] xdp: Add devmap_idx map type for looking up devices by ifindex Toke Høiland-Jørgensen
2019-02-21 15:23 ` Jesper Dangaard Brouer
2019-02-21 15:50 ` Toke Høiland-Jørgensen
2019-02-21 21:49 ` Jakub Kicinski
2019-02-21 23:02 ` Toke Høiland-Jørgensen
2019-02-22 0:32 ` Jakub Kicinski
2019-02-22 9:47 ` Toke Høiland-Jørgensen
2019-02-22 21:30 ` Jakub Kicinski
2019-02-23 11:52 ` Toke Høiland-Jørgensen
2019-02-23 23:19 ` kbuild test robot
2019-02-23 23:28 ` kbuild test robot
2019-02-21 15:19 ` Jesper Dangaard Brouer [this message]
2019-02-21 15:52 ` [PATCH net-next 1/2] xdp: Always use a devmap for XDP_REDIRECT to a device Toke Høiland-Jørgensen
2019-02-22 0:36 ` Jakub Kicinski
2019-02-22 10:13 ` Toke Høiland-Jørgensen
2019-02-22 21:37 ` Jakub Kicinski
2019-02-23 10:43 ` Jesper Dangaard Brouer
2019-02-23 12:11 ` Toke Høiland-Jørgensen
2019-02-25 18:47 ` Jakub Kicinski
2019-02-26 11:00 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221161950.1938cc8c@carbon \
--to=brouer@redhat.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).