From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A7FCC43381 for ; Thu, 21 Feb 2019 15:20:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE32C2083B for ; Thu, 21 Feb 2019 15:19:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726443AbfBUPT6 convert rfc822-to-8bit (ORCPT ); Thu, 21 Feb 2019 10:19:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38734 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725866AbfBUPT6 (ORCPT ); Thu, 21 Feb 2019 10:19:58 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 48F98E6A83; Thu, 21 Feb 2019 15:19:58 +0000 (UTC) Received: from carbon (ovpn-200-42.brq.redhat.com [10.40.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2082D1001DC1; Thu, 21 Feb 2019 15:19:51 +0000 (UTC) Date: Thu, 21 Feb 2019 16:19:50 +0100 From: Jesper Dangaard Brouer To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: David Miller , netdev@vger.kernel.org, Daniel Borkmann , Alexei Starovoitov , brouer@redhat.com Subject: Re: [PATCH net-next 1/2] xdp: Always use a devmap for XDP_REDIRECT to a device Message-ID: <20190221161950.1938cc8c@carbon> In-Reply-To: <155075021399.13610.12521373406832889226.stgit@alrua-x1> References: <155075021399.13610.12521373406832889226.stgit@alrua-x1> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 21 Feb 2019 15:19:58 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org You forgot at cover letter describing why we are doing this... even-though is should be obvious from the performance results ;-) On Thu, 21 Feb 2019 12:56:54 +0100 Toke Høiland-Jørgensen wrote: > Before patch: > xdp_redirect: 5426035 pkt/s > xdp_redirect_map: 8412754 pkt/s > > After patch: > xdp_redirect: 8314702 pkt/s > xdp_redirect_map: 8411854 pkt/s > > This corresponds to a 53% increase in xdp_redirect performance, or a > reduction in per-packet processing time by 64 nanoseconds. (1/5426035-1/8314702)*10^9 = 64.0277 almost exactly 64 nanosec (1/8412754-1/8411854)*10^9 = -0.012 => no regression for xdp_redirect_map -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer