From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CAC6C43381 for ; Thu, 21 Feb 2019 18:11:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5480820836 for ; Thu, 21 Feb 2019 18:11:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728160AbfBUSL3 (ORCPT ); Thu, 21 Feb 2019 13:11:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9979 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725831AbfBUSL3 (ORCPT ); Thu, 21 Feb 2019 13:11:29 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8FC6359446; Thu, 21 Feb 2019 18:11:29 +0000 (UTC) Received: from localhost (ovpn-200-19.brq.redhat.com [10.40.200.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 900AF5D70E; Thu, 21 Feb 2019 18:11:26 +0000 (UTC) Date: Thu, 21 Feb 2019 19:11:21 +0100 From: Stefano Brivio To: David Ahern , Paolo Abeni Cc: netdev@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH net v2] ipv6: route: purge exception on removal Message-ID: <20190221191121.4b9d6dda@redhat.com> In-Reply-To: References: <1cf1aef01dd9294347df6e339d2f8f042172fb54.1550679150.git.pabeni@redhat.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 21 Feb 2019 18:11:29 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 21 Feb 2019 10:10:32 -0500 David Ahern wrote: > I am surprised this was not found by the existing pmtu script which > creates exceptions. Please add this test case to selftests to capture > this specific set of events. I think the reason is that, to keep the cleanup function minimal, I just decided to tear down namespaces after tests, and the tests won't catch this. Paolo, I guess you could either make cleanup() symmetric with the setup_routing() function (but then we don't catch issues related to namespaces teardown), or introduce just two tests (IPv4 and IPv6) doing this with one existing tunnel setup (and we don't have variability on device types, but I don't think it's very relevant). The alternative of doubling every test (with namespace *and* "orderly" teardown) looks a bit overkill to me. -- Stefano