From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 094DAC43381 for ; Thu, 21 Feb 2019 22:11:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD6282083B for ; Thu, 21 Feb 2019 22:11:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550787061; bh=VkvBPnbN5NsDynKMRzIWVzkZYwav70vY96njjjnjgOQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Li+DIG6ghVxnFNByOtqADZc1Bjh1qlYmd1RPjJ49elzE0U9ATTRDNKZlSwLtlBlzx Cg4Wbwjs/+T8jp8b2A+X6MEMTGZ4A6cRXnHaS9TQiMyBqKHXhiADMEtw7JmE7yUS4X v1RDg/JN/J9V4oXtq7tlFVZZP0i4hz/fx1Zq5o9M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726237AbfBUWLA (ORCPT ); Thu, 21 Feb 2019 17:11:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:43738 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726035AbfBUWLA (ORCPT ); Thu, 21 Feb 2019 17:11:00 -0500 Received: from localhost (unknown [77.138.135.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3AB44207E0; Thu, 21 Feb 2019 22:10:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550787059; bh=VkvBPnbN5NsDynKMRzIWVzkZYwav70vY96njjjnjgOQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cduJyvbAlj6xWWb33Qop4e2RIFpyOcfk0ED1y/LmoRyVDAp6VHlB2VxOZLKrpV00V DJm/WyvkecDZR6z5JmEo+krsMgaPvZLV7ii/jD4G4M91SdTtALfih+X5nXHEoinZc1 AOuJFuWsajnmsiz4QpA5NsAj34t1I2hYZ3cNIStI= Date: Fri, 22 Feb 2019 00:10:52 +0200 From: Leon Romanovsky To: Stephen Hemminger Cc: Steve Wise , dsahern@gmail.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH v1 iproute2-next 2/4] Sync up rdma_netlink.h Message-ID: <20190221221052.GG23561@mtr-leonro.mtl.com> References: <20190221105631.7dfa5217@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="n/aVsWSeQ4JHkrmm" Content-Disposition: inline In-Reply-To: <20190221105631.7dfa5217@shemminger-XPS-13-9360> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --n/aVsWSeQ4JHkrmm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 21, 2019 at 10:56:31AM -0800, Stephen Hemminger wrote: > On Thu, 21 Feb 2019 08:19:07 -0800 > Steve Wise wrote: > > > Pull in the latest rdma_netlink.h to get the RDMA_NLDEV_CMD_NEWLINK / > > RDMA_NLDEV_CMD_DELLINK API. > > > > Signed-off-by: Steve Wise > > --- > > rdma/include/uapi/rdma/rdma_netlink.h | 74 +++++++++++++++++++++++++++-------- > > 1 file changed, 58 insertions(+), 16 deletions(-) > > > > diff --git a/rdma/include/uapi/rdma/rdma_netlink.h b/rdma/include/uapi/rdma/rdma_netlink.h > > index 04c80cebef49..23a90ad52485 100644 > > --- a/rdma/include/uapi/rdma/rdma_netlink.h > > +++ b/rdma/include/uapi/rdma/rdma_netlink.h > > @@ -5,8 +5,7 @@ > > #include > > > > enum { > > - RDMA_NL_RDMA_CM = 1, > > - RDMA_NL_IWCM, > > + RDMA_NL_IWCM = 2, > > RDMA_NL_RSVD, > > RDMA_NL_LS, /* RDMA Local Services */ > > RDMA_NL_NLDEV, /* RDMA device interface */ > > You can't just drop elements from user ABI headers. > That is a break of kernel ABI guarantee. In RDMA subsystem, we have less pedantic rules and are removing unused and mistakenly added code. This removal scheme was suggested by Linus - remove and see who is complaining. The big advantage of RDMA is that we know exactly what is in use by our consumers. In this case, we knew for sure that no one is using RDMA_NL_RDMA_CM, and it never was backed by working user space. More on that, the talks of RDMA_NL_RDMA_CM removal started a long time ago, but took time till the patch was actually sent. So yes, if people use this enum value as subsidiary to 1, they will break. > > Instead, mark unused elements: > enum { > RDMA_NL_RDMA_CM = 1, /* deprecated */ > RDMA_NL_IWCM, > ... --n/aVsWSeQ4JHkrmm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJcbyHrAAoJEORje4g2clinpXQP/127kXNG5UuY/Stoz1yD+g56 5jEFMX4uax/wV15AeEoNbx/KWNzbITmYGx8lVWj7+brMECdUBvH8V62TY6ppqGMd xjJ8eJ9SYJxSQrjn1/AqWGAJ/2wROppM2tpjxesezvDfW+OXQpSAKrDYbH+JhlII sK+fr6QQLmyukJkMKjGECzwLqZCtjDgVOzcwqOH0bp5R6Vb9vBmDhPM83wAfmEqO RbYn3TWMtkz/X4gIkt8S/R9fGaBDs+/o3o7kllClkef3bEqtKrHpGYINwgkXwzPX sExL5/AJU4IIbnZBgQFDWea/NdPbShVLsSr6o1eU+r8IsPzR+n0D2IW4CnzekkX0 JbAbEx3pambTpvd4dfB2Asq7vZ22yDdE7rpEsjVpqsnMhOAJse+3CAMQpJjwKvia tgfqdpX/HWF55bO06Rhk4PWnjBY2jltq8jJuQnSNNttB95jwE1pqVzREghweLqza Cp0YDKPx6DH71uYiD4dN4IvTBZkNq4xerxxbzWjN+wJEZPMxIB56qjmjh5oFYHZu Y7aniBuI5ixAelUv34l9KK1cFPqtVKk9Y7IrD1ITaVZvpd5HpQKXD4ly60C3V9If MiRxS5PADkzkub3ZWMk1cUspT1mSt3NL1Y3PuQKvUT1gdhxDgb8q5v0LhEQ+CgvB UBOWucJW1tCwM7vTKOqY =0MMq -----END PGP SIGNATURE----- --n/aVsWSeQ4JHkrmm--