From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79E92C43381 for ; Fri, 22 Feb 2019 19:53:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51C9E206BB for ; Fri, 22 Feb 2019 19:53:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726820AbfBVTx5 (ORCPT ); Fri, 22 Feb 2019 14:53:57 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:57220 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725892AbfBVTxz (ORCPT ); Fri, 22 Feb 2019 14:53:55 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C40EC14A8E40F; Fri, 22 Feb 2019 11:53:54 -0800 (PST) Date: Fri, 22 Feb 2019 11:53:54 -0800 (PST) Message-Id: <20190222.115354.1384012175579493298.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, andrew@lunn.ch, vivien.didelot@gmail.com, idosch@mellanox.com, jiri@mellanox.com, rmk+kernel@armlinux.org.uk Subject: Re: [PATCH net-next 0/2] net: dsa: VLAN devices w/ filtering From: David Miller In-Reply-To: <20190220223539.22106-1-f.fainelli@gmail.com> References: <20190220223539.22106-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 22 Feb 2019 11:53:55 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Florian Fainelli Date: Wed, 20 Feb 2019 14:35:37 -0800 > This patch series supports having VLAN devices on top of DSA/switch > ports while the switch has VLAN filtering globally turned on (as is the > case with Broadcom switches). Whether the switch does global or per-port > VLAN filtering, having VLAN entries for these VLAN devices is > beneficial. > > We take care of a few possibly problematic cases: > > - adding a VLAN device while there is an existing VLAN entry created by > a VLAN aware bridge. The entire bridge's VLAN database and not just > the specific bridge port is being checked to be safe and conserative > > - adding a bridge VLAN entry when there is an existing VLAN device > created is also not possible because that would lead to the bridge > being able to manipulate the VLAN device's VID/attributes under its feet > > - enslaving a VLAN device into a VLAN aware bridge since that duplicates > functionality already offered by the VLAN aware bridge > > Here are the different test cases that were run to exercise this: ... Series applied, thanks Florian.