From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72C8DC43381 for ; Fri, 22 Feb 2019 23:32:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B1AE2070D for ; Fri, 22 Feb 2019 23:32:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbfBVXcO (ORCPT ); Fri, 22 Feb 2019 18:32:14 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:59842 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbfBVXcO (ORCPT ); Fri, 22 Feb 2019 18:32:14 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2837C14AD9474; Fri, 22 Feb 2019 15:32:13 -0800 (PST) Date: Fri, 22 Feb 2019 15:32:12 -0800 (PST) Message-Id: <20190222.153212.833297531455107737.davem@davemloft.net> To: vkoul@kernel.org Cc: linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, niklas.cassel@linaro.org, andrew@lunn.ch, f.fainelli@gmail.com, nsekhar@ti.com, peter.ujfalusi@ti.com, marc.w.gonzalez@free.fr Subject: Re: [PATCH net-next v4 0/2] net: phy: at803x: Update delays for RGMII modes From: David Miller In-Reply-To: <20190221102315.12946-1-vkoul@kernel.org> References: <20190221102315.12946-1-vkoul@kernel.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 22 Feb 2019 15:32:13 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vinod Koul Date: Thu, 21 Feb 2019 15:53:13 +0530 > Peter[1] reported that patch cd28d1d6e52e: ("net: phy: at803x: Disable > phy delay for RGMII mode") caused regression on am335x-evmsk board. > This board expects the Phy delay to be enabled but specified RGMII mode > which refers to delays being disabled. So fix this by disabling delay only > for RGMII mode and enable for RGMII_ID and RGMII_TXID/RXID modes. > > While at it, as pointed by Dave, don't inline the helpers. > > [1]: https://www.spinics.net/lists/netdev/msg550749.html > > Changes in v4: > - fix log & comments nbased on Marc's feedback Series applied, thanks.