From: Hangbin Liu <liuhangbin@gmail.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: "Linus Lüssing" <linus.luessing@c0d3.blue>,
netdev@vger.kernel.org, roopa@cumulusnetworks.com,
bridge@lists.linux-foundation.org, davem@davemloft.net,
yinxu@redhat.com,
"Sebastian Gottschall" <s.gottschall@newmedia-net.de>
Subject: Re: [Bridge] [PATCH net] net: bridge: remove ipv6 zero address check in mcast queries
Date: Fri, 22 Feb 2019 20:49:04 +0800 [thread overview]
Message-ID: <20190222124904.GO10051@dhcp-12-139.nay.redhat.com> (raw)
In-Reply-To: <2f60dc0a-f6ee-06ad-f60c-15e035574a75@cumulusnetworks.com>
On Fri, Feb 22, 2019 at 01:16:53PM +0200, Nikolay Aleksandrov wrote:
> >
> > For consistency with other vendors and rfc, I would prefer to remove zero address election.
> > For compatibility with previous users, I'm also OK to revert it.
> > > Regards
> > Hangbin
> >
>
> Hi,
> In this case I'd suggest the following course of action:
> - For -net/-stable revert the change since backporting new options is a
> no-go and we need to restore the bridge state
> - After -net is merged in net-next, for net-next if you'd like add it
> as an option and also exclude it from elections when the option is
> enabled (for example something like multicast_nonzero_src_querier).
> Just please use the boolopt api and don't add new fields/attr ids.
> Obviously by default this option will be off to be backwards
> compatible and avoid surprise mcast flood.
>
> Or just leave it reverted. :)
This makes sense to me. Thanks for your suggestions.
Regards
Hangbin
next prev parent reply other threads:[~2019-02-22 12:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 0:50 [net:master 17/19] net//bridge/br_multicast.c:1432:32: error: 'union <anonymous>' has no member named 'ip6'; did you mean 'ip4'? kbuild test robot
2018-10-27 7:10 ` Nikolay Aleksandrov
2018-10-27 9:07 ` [PATCH net] net: bridge: remove ipv6 zero address check in mcast queries Nikolay Aleksandrov
2018-10-28 15:20 ` [Bridge] " Stephen Hemminger
2018-10-28 16:09 ` Nikolay Aleksandrov
2018-10-29 1:33 ` Hangbin Liu
2018-12-13 16:10 ` [Bridge] " Linus Lüssing
2018-12-14 2:32 ` Ying Xu
2018-12-17 13:15 ` [Bridge] " Linus Lüssing
2019-02-21 8:01 ` Hangbin Liu
2019-02-21 13:20 ` Nikolay Aleksandrov
2019-02-22 7:57 ` Hangbin Liu
2019-02-22 11:16 ` Nikolay Aleksandrov
2019-02-22 12:49 ` Hangbin Liu [this message]
2018-10-29 2:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222124904.GO10051@dhcp-12-139.nay.redhat.com \
--to=liuhangbin@gmail.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linus.luessing@c0d3.blue \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=s.gottschall@newmedia-net.de \
--cc=yinxu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).