From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7494C43381 for ; Fri, 22 Feb 2019 12:49:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D219207E0 for ; Fri, 22 Feb 2019 12:49:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cp4suVLV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726839AbfBVMtR (ORCPT ); Fri, 22 Feb 2019 07:49:17 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:36068 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726087AbfBVMtP (ORCPT ); Fri, 22 Feb 2019 07:49:15 -0500 Received: by mail-pl1-f194.google.com with SMTP id k2so1086010plt.3 for ; Fri, 22 Feb 2019 04:49:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5gLp8zNrQenZmkQOHDe23IakIFO7pYZ3fcPW0z5/sqs=; b=cp4suVLVK722LaZ5k18RAqHnohgkrdPG698TH2yJ2zTuMnat3OdwZULefiEglX4ayK 8G81BWMwwSmXD/3CrgiQBOmOupJsR1pWEn2EOrjqn5OjG1XskUwBaFwM+Buoor14Ij8R +ADu3qDBsxhCJNc2Wop7qzWnSQRP3UYGEmTSwBjDO5hF6u6F4s5bKW5TNXMGEM0OLdnl 55aMl4hXE575daqClVRmWziCB6/9B7YUS7QfiJlEDOHkcJyjzkXoJZ6OZqukyqBAA281 iVH+PY5u/dSJKhZMWkixdgxkqHs2KMzT7DzsIeIU11iX6+HQXm7vPiSaLzy4EQlfUhGD xeRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5gLp8zNrQenZmkQOHDe23IakIFO7pYZ3fcPW0z5/sqs=; b=D+P+ov/ze/+p6+Mdt3TRMNSS9mm5syP7btaj3EBb9xLLhG2r4iLBzg7Cz0Pa2DkYV3 Or4YARLM9yk+sYM0mSeCGng1Il52/8SHkziHvBMSvL4WkGqXxH6TktiNLZCTukQS5rT4 G9puFk2smazo0rabBN/a1Kk+gf051p0ms16u4P3Fm7VlbGTX80zb9wSr1ttT35/QCwrg 9TAw53DLGK86Ey447lJPd3t2oQY0dtISXHAQRCjN5E4rF3jIcNOExvoZNQSA4RquX17Z OUBnbp6fBQu4dzopU0SRmF4ebYfnZfshtEMklD16E5Skbs7aQCgbxLpZ0XUdMARkW5w/ z4yg== X-Gm-Message-State: AHQUAubCC0jk8NKk9CxrlYGJHBGf74u/x1FLNh18JWqNQ0DsfqSiJMQL M29cn6QQIWvY3xFtcdrPmRdeMGetnIM= X-Google-Smtp-Source: AHgI3IZJjyqoqd8hTjA84nk/bptyB+Pp7UHUzINsOf6sk89j9FiQRHWdDMzMOlObuyocwAKap+/8Mw== X-Received: by 2002:a17:902:1008:: with SMTP id b8mr3959290pla.252.1550839754995; Fri, 22 Feb 2019 04:49:14 -0800 (PST) Received: from dhcp-12-139.nay.redhat.com ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id b6sm2612971pfo.27.2019.02.22.04.49.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Feb 2019 04:49:14 -0800 (PST) Date: Fri, 22 Feb 2019 20:49:04 +0800 From: Hangbin Liu To: Nikolay Aleksandrov Cc: Linus =?iso-8859-1?Q?L=FCssing?= , netdev@vger.kernel.org, roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org, davem@davemloft.net, yinxu@redhat.com, Sebastian Gottschall Subject: Re: [Bridge] [PATCH net] net: bridge: remove ipv6 zero address check in mcast queries Message-ID: <20190222124904.GO10051@dhcp-12-139.nay.redhat.com> References: <90c5f2fe-1743-6b17-2e44-eba58cdbbb35@cumulusnetworks.com> <20181027090747.22104-1-nikolay@cumulusnetworks.com> <20181029013316.GK24677@leo.usersys.redhat.com> <20181213161027.GC1713@otheros> <20190221080114.GL10051@dhcp-12-139.nay.redhat.com> <9db055dd-6486-1d6e-7dce-edc511650af9@cumulusnetworks.com> <20190222075705.GN10051@dhcp-12-139.nay.redhat.com> <2f60dc0a-f6ee-06ad-f60c-15e035574a75@cumulusnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f60dc0a-f6ee-06ad-f60c-15e035574a75@cumulusnetworks.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Feb 22, 2019 at 01:16:53PM +0200, Nikolay Aleksandrov wrote: > > > > For consistency with other vendors and rfc, I would prefer to remove zero address election. > > For compatibility with previous users, I'm also OK to revert it. > > > Regards > > Hangbin > > > > Hi, > In this case I'd suggest the following course of action: > - For -net/-stable revert the change since backporting new options is a > no-go and we need to restore the bridge state > - After -net is merged in net-next, for net-next if you'd like add it > as an option and also exclude it from elections when the option is > enabled (for example something like multicast_nonzero_src_querier). > Just please use the boolopt api and don't add new fields/attr ids. > Obviously by default this option will be off to be backwards > compatible and avoid surprise mcast flood. > > Or just leave it reverted. :) This makes sense to me. Thanks for your suggestions. Regards Hangbin