From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=t95Q=Q5=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id CF4C6C43381
	for <netdev@archiver.kernel.org>; Fri, 22 Feb 2019 14:30:09 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 906EE2075C
	for <netdev@archiver.kernel.org>; Fri, 22 Feb 2019 14:30:09 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="ZvcY0Iu0"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726439AbfBVOaI (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 22 Feb 2019 09:30:08 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:34681 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726352AbfBVOaI (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 22 Feb 2019 09:30:08 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=UlNTH2OknAwWpbVzNWbob9aCg22nw1E02gaV8sMxAps=; b=ZvcY0Iu0rIHSAyeNoaI6rsMLki
        nYhCyohaKh/vBdgc2hFOeRH/d25tX7m9yuMA5bPS8+jmarF/Ks5NEyvcNEP2RgO4UnQo+gzkMEe86
        877QufQCosT1VwqA7UAh0v2kyb4MAaBA/IACSFveE9J113H9kJHXKjQHIQSVbAOnMODs=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1gxBpz-0007DI-10; Fri, 22 Feb 2019 15:30:03 +0100
Date:   Fri, 22 Feb 2019 15:30:03 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Vinod Koul <vkoul@kernel.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        linux-arm-msm@vger.kernel.org,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Xiaofei Shen <xiaofeis@codeaurora.org>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Niklas Cassel <niklas.cassel@linaro.org>,
        netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: Inherit dev addr from master
Message-ID: <20190222143003.GL5653@lunn.ch>
References: <20190222125654.12478-1-vkoul@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190222125654.12478-1-vkoul@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Fri, Feb 22, 2019 at 06:26:54PM +0530, Vinod Koul wrote:
> From: Xiaofei Shen <xiaofeis@codeaurora.org>
> 
> When we create slave netdevice, the dev addr is inherited from master
> but the master dev addr maybe NULL at that time, so inherit it again
> while opening the slave.

Hi Xiaofei, Vinod

Inheriting it twice seems a bit clumsy. Can the first inherit be
removed? Can you change your MAC driver to set its MAC address in
probe?

	Andrew