From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E0CFC43381 for ; Fri, 22 Feb 2019 16:51:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 05C0120700 for ; Fri, 22 Feb 2019 16:51:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726485AbfBVQvy (ORCPT ); Fri, 22 Feb 2019 11:51:54 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:32789 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725986AbfBVQvy (ORCPT ); Fri, 22 Feb 2019 11:51:54 -0500 X-Originating-IP: 90.88.23.190 Received: from bootlin.com (aaubervilliers-681-1-81-190.w90-88.abo.wanadoo.fr [90.88.23.190]) (Authenticated sender: maxime.chevallier@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id C150BFF808; Fri, 22 Feb 2019 16:51:51 +0000 (UTC) Date: Fri, 22 Feb 2019 17:51:50 +0100 From: Maxime Chevallier To: Heiner Kallweit Cc: Andrew Lunn , Florian Fainelli , David Miller , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next] net: phy: let genphy_c45_read_abilities also check aneg capability Message-ID: <20190222175150.1cadc919@bootlin.com> In-Reply-To: References: X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello Heiner, On Fri, 22 Feb 2019 08:23:04 +0100 Heiner Kallweit wrote: >When using genphy_c45_read_abilities() as get_features callback we >also have to set the autoneg capability in phydev->supported. >@@ -336,6 +336,17 @@ int genphy_c45_pma_read_abilities(struct phy_device *phydev) This makes the helper not reading PMA-only registers, so the naming isn't really relevant anymore, but that's a small detail. Other than that, Reviewed-by: Maxime Chevallier Thanks, Maxime