From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B7F7C43381 for ; Fri, 22 Feb 2019 17:49:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3AEC120700 for ; Fri, 22 Feb 2019 17:49:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727103AbfBVRtu (ORCPT ); Fri, 22 Feb 2019 12:49:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47015 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726498AbfBVRtt (ORCPT ); Fri, 22 Feb 2019 12:49:49 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 009547DCE7; Fri, 22 Feb 2019 17:49:49 +0000 (UTC) Received: from localhost (ovpn-200-19.brq.redhat.com [10.40.200.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4FEB95D9CA; Fri, 22 Feb 2019 17:49:46 +0000 (UTC) Date: Fri, 22 Feb 2019 18:49:40 +0100 From: Stefano Brivio To: Paolo Abeni Cc: netdev@vger.kernel.org, "David S. Miller" , David Ahern Subject: Re: [PATCH net 1/2] selftests: pmtu: disable dad in all namespaces Message-ID: <20190222184940.56d36a76@redhat.com> In-Reply-To: <1d298b6839828c96cd8a0f50bdfac893cc645895.1550851038.git.pabeni@redhat.com> References: <1d298b6839828c96cd8a0f50bdfac893cc645895.1550851038.git.pabeni@redhat.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 22 Feb 2019 17:49:49 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 22 Feb 2019 17:06:32 +0100 Paolo Abeni wrote: > Otherwise, the configured IPv6 address could be still "tentative" > at test time, possibly causing tests failures. > We can also drop some sleep along the code and decrease the > timeout for most commands so that the test runtime decreases. Thanks for fixing this! I tried this back then and it didn't work, perhaps some DAD changes intervened meanwhile (or I simply tried it wrong). Just one comment: > Fixes: d1f1b9cbf34c ("selftests: net: Introduce first PMTU test") > Signed-off-by: Paolo Abeni > --- > tools/testing/selftests/net/pmtu.sh | 28 +++++++++++++--------------- > 1 file changed, 13 insertions(+), 15 deletions(-) > > diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh > index e2c94e47707c..634e91e8fe25 100755 > --- a/tools/testing/selftests/net/pmtu.sh > +++ b/tools/testing/selftests/net/pmtu.sh > @@ -263,8 +263,6 @@ setup_fou_or_gue() { > > ${ns_a} ip link set ${encap}_a up > ${ns_b} ip link set ${encap}_b up > - > - sleep 1 > } > > setup_fou44() { > @@ -302,6 +300,10 @@ setup_gue66() { > setup_namespaces() { > for n in ${NS_A} ${NS_B} ${NS_R1} ${NS_R2}; do > ip netns add ${n} || return 1 > + > + # disable dad, so that we don't have to wait to use the > + # configured IPv6 addresses For consistency: "Disable DAD ..." -- Stefano