From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1273EC43381 for ; Sat, 23 Feb 2019 21:21:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DBDFD20651 for ; Sat, 23 Feb 2019 21:21:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729440AbfBWVVW (ORCPT ); Sat, 23 Feb 2019 16:21:22 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:42550 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729002AbfBWVVV (ORCPT ); Sat, 23 Feb 2019 16:21:21 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 616CA14BEDAE0; Sat, 23 Feb 2019 13:21:20 -0800 (PST) Date: Sat, 23 Feb 2019 13:21:17 -0800 (PST) Message-Id: <20190223.132117.343025457687449183.davem@davemloft.net> To: laoar.shao@gmail.com Cc: daniel@iogearbox.net, edumazet@google.com, joe@perches.com, xiyou.wangcong@gmail.com, netdev@vger.kernel.org, shaoyafang@didiglobal.com Subject: Re: [PATCH v3 net-next 2/2] net: sock: undefine SOCK_DEBUGGING From: David Miller In-Reply-To: <1550413592-7877-3-git-send-email-laoar.shao@gmail.com> References: <1550413592-7877-1-git-send-email-laoar.shao@gmail.com> <1550413592-7877-3-git-send-email-laoar.shao@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 23 Feb 2019 13:21:20 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yafang Shao Date: Sun, 17 Feb 2019 22:26:32 +0800 > SOCK_DEBUG() is a old facility for debugging. > If the user want to use it for debugging, the user must modify the > application first, that doesn't seem like a good way. > Now we have more powerful facilities, i.e. bpf or tracepoint, for this kind > of debugging purpose. > So we'd better disable it by default. > The reason why I don't remove it comepletely is that someone may still > would like to use it for debugging. > > Signed-off-by: Yafang Shao > Suggested-by: Joe Perches Sorry, I'm not applying this. You are forcing everyone who wants to use this to add a curstom local source code change into their build. I'm OK with patch #1, and Eric suggested it, so if you want to submit that separately that's fine.