From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E87A7C43381 for ; Sun, 24 Feb 2019 02:30:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B497C20663 for ; Sun, 24 Feb 2019 02:30:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728029AbfBXCaa (ORCPT ); Sat, 23 Feb 2019 21:30:30 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:44730 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726405AbfBXCaa (ORCPT ); Sat, 23 Feb 2019 21:30:30 -0500 Received: from localhost (c-67-183-62-245.hsd1.wa.comcast.net [67.183.62.245]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5B5CB14BF47F9; Sat, 23 Feb 2019 18:30:29 -0800 (PST) Date: Sat, 23 Feb 2019 18:30:05 -0800 (PST) Message-Id: <20190223.183005.233475723803300804.davem@davemloft.net> To: xiyou.wangcong@gmail.com Cc: laoar.shao@gmail.com, daniel@iogearbox.net, edumazet@google.com, joe@perches.com, netdev@vger.kernel.org, shaoyafang@didiglobal.com Subject: Re: [PATCH v3 net-next 2/2] net: sock: undefine SOCK_DEBUGGING From: David Miller In-Reply-To: References: <1550413592-7877-3-git-send-email-laoar.shao@gmail.com> <20190223.132117.343025457687449183.davem@davemloft.net> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 23 Feb 2019 18:30:29 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Cong Wang Date: Sat, 23 Feb 2019 17:11:08 -0800 > On Sat, Feb 23, 2019 at 1:21 PM David Miller wrote: >> >> You are forcing everyone who wants to use this to add a curstom local >> source code change into their build. > > What's wrong with this? People carry custom changes in anyway, > do we really need to care about all the downstream changes? No way am I allowing this, sorry. Either it's something in the tree that people can use or it's a crap hack. When we see stuff like this in a driver we ask the driver author to remove it.