From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, andrew.hendry@gmail.com
Subject: Re: [PATCH net] net/x25: fix a race in x25_bind()
Date: Sat, 23 Feb 2019 18:42:54 -0800 (PST) [thread overview]
Message-ID: <20190223.184254.1384538225076694532.davem@davemloft.net> (raw)
In-Reply-To: <20190223212459.238465-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Sat, 23 Feb 2019 13:24:59 -0800
> syzbot was able to trigger another soft lockup [1]
>
> I first thought it was the O(N^2) issue I mentioned in my
> prior fix (f657d22ee1f "net/x25: do not hold the cpu
> too long in x25_new_lci()"), but I eventually found
> that x25_bind() was not checking SOCK_ZAPPED state under
> socket lock protection.
>
> This means that multiple threads can end up calling
> x25_insert_socket() for the same socket, and corrupt x25_list
...
> Fixes: 90c27297a9bf ("X.25 remove bkl in bind")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: andrew hendry <andrew.hendry@gmail.com>
Applied and queued up for -stable, thanks Eric.
prev parent reply other threads:[~2019-02-24 2:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 21:24 [PATCH net] net/x25: fix a race in x25_bind() Eric Dumazet
2019-02-24 2:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190223.184254.1384538225076694532.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew.hendry@gmail.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox