From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52698C43381 for ; Sat, 23 Feb 2019 09:05:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1959D2084F for ; Sat, 23 Feb 2019 09:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550912733; bh=xjAgkgV6ltRpK9zvSESwWkhZZIgCRlwLzqdBp9d7wY4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Qbx4tflrR/egEkr49dr8ExpUa1WJsDc6YRXePJl21HRHjMnyRaOiIPwg05f1SZN6F m2s5WIniYSJu7KShIZfQ4HnUlkt5/ujbxyFeDRGmvs8KNpccleExPwFZEN2HD17xzo B+WzZG/X7DGAySY124jk2TyA6k912+nj7S33TRtg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726318AbfBWJFb (ORCPT ); Sat, 23 Feb 2019 04:05:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:51866 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbfBWJFb (ORCPT ); Sat, 23 Feb 2019 04:05:31 -0500 Received: from localhost (unknown [77.138.135.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 95D8E2084F; Sat, 23 Feb 2019 09:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550912730; bh=xjAgkgV6ltRpK9zvSESwWkhZZIgCRlwLzqdBp9d7wY4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GpufAWmvBKZmzUibHgqPL/fVGF+EbehajCUu7bzT3c/WgA3VltM5df2jABJAwvMgZ TGYaVW46fRBn10a9FaoWcLD9GZNjypWUbKopOsGZD99Wpcw4sUilR8tlkYs9CPyT99 4aAzwcdyHvrur7Uej15IJ7CRwwITEoFW9BbT07KU= Date: Sat, 23 Feb 2019 11:05:28 +0200 From: Leon Romanovsky To: Steve Wise Cc: 'David Ahern' , 'netdev' , 'RDMA mailing list' , 'Stephen Hemminger' Subject: Re: [PATCH iproute2-next v1 05/19] rdma: Move resource PD logic to separate file Message-ID: <20190223090528.GL23561@mtr-leonro.mtl.com> References: <20190220072136.3840-1-leon@kernel.org> <20190220072136.3840-6-leon@kernel.org> <01d601d4ca22$28f83140$7ae893c0$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GBuTPvBEOL0MYPgd" Content-Disposition: inline In-Reply-To: <01d601d4ca22$28f83140$7ae893c0$@opengridcomputing.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --GBuTPvBEOL0MYPgd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 21, 2019 at 02:15:16PM -0600, Steve Wise wrote: > > > > -----Original Message----- > > From: linux-rdma-owner@vger.kernel.org > owner@vger.kernel.org> On Behalf Of Leon Romanovsky > > Sent: Wednesday, February 20, 2019 1:21 AM > > To: David Ahern > > Cc: Leon Romanovsky ; netdev > > ; RDMA mailing list > rdma@vger.kernel.org>; Stephen Hemminger > > > > Subject: [PATCH iproute2-next v1 05/19] rdma: Move resource PD logic to > > separate file > > > > From: Leon Romanovsky > > > > Logically separate resource PD logic to separate file, > > in order to make PD specific logic self-contained. > > > > Signed-off-by: Leon Romanovsky > > --- > > Why does it need to be self contained? The main res.c file was so large that at least for me wasn't clear how and what to refactor. Such separation allowed me to start code cleanup by identification of duplicate places. > > Reviewed-by: Steve Wise > > --GBuTPvBEOL0MYPgd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJccQzYAAoJEORje4g2clinAcIP/087lmIZvJ/7k8/scaFiiiMg s/eTp0Qsqfz7FE4OXArdSc9EyHCO+2KNq4tii2fz52hGckloZGWOE7Th6nGBZisD e2+ArQe0jyPHPIw1moLpRL2k+9EXaB7cxLU9O7SeTrhoHufzWB4d7sFBH3OoJfxp CKdXV9YOA/84DGsJz1EaXMSPpqHjCTjaKWOVQrzas5OdDEWk/vxRJ3PzPuzPtq/g oNg+U/ZlulD9+ZXp72SI1q22T0acsxWvW8PdXIIi8C4aeFS5DssHGZrQ0vshBi1C 9iovaHet6aCj2ALCr63QbQ+oa9BDeIOTyadzqeicfhAyDjqSQ32NtNqpfOdXeSbV 0o834K5WwXvlVmdlRdomeICGKrUjFCwTYfeZ14tbtlCAVDvNOrbZIc5muKXoehI5 eiYxNHMcGKzhxZUsq/Vi2rdF72o+3g/dm3iO089TtvR6jRke/3JK+V2wIXzPHYKO MypCMhOv7SeshoR8NhFanWP8eq7luBCvLvlZXWNwq9cnkiF0tZfgD7ACZQ5zbCu9 hj8US0vn5WX4lo+BUD87WC4eXVxYHvCtDLL5AX5SuhB/B4E2whOYmmidjHTNqm8R NpjSCUJtqe88xT9GojF/EszFUfcyd0DYqGQSKFoFUf1kii9XHtqyOo07dEpukxu8 A8KSq8E8rhDbULebniuU =g5dw -----END PGP SIGNATURE----- --GBuTPvBEOL0MYPgd--