* [PATCH] net: ax25: Add SPDX License to fix missing License warning
@ 2019-02-23 11:11 Jules Irenge
2019-02-23 12:58 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jules Irenge @ 2019-02-23 11:11 UTC (permalink / raw)
To: jreuter
Cc: linux-hams, linux-kernel, davem, ralf, netdev, outreachy-kernel,
gregkh, jbi.octave
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
net/ax25/af_ax25.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
index 5d01edf8d819..5048790a75f6 100644
--- a/net/ax25/af_ax25.c
+++ b/net/ax25/af_ax25.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ax25: Add SPDX License to fix missing License warning
2019-02-23 11:11 [PATCH] net: ax25: Add SPDX License to fix missing License warning Jules Irenge
@ 2019-02-23 12:58 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-02-23 12:58 UTC (permalink / raw)
To: Jules Irenge
Cc: jreuter, linux-hams, linux-kernel, davem, ralf, netdev,
outreachy-kernel
On Sat, Feb 23, 2019 at 11:11:00AM +0000, Jules Irenge wrote:
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
I know I never take patches without any changelog text :(
> ---
> net/ax25/af_ax25.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
> index 5d01edf8d819..5048790a75f6 100644
> --- a/net/ax25/af_ax25.c
> +++ b/net/ax25/af_ax25.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
That is the incorrect license of this file!
NEVER add or modify a SPDX line if you do not really really really know
what you are doing. Putting the wrong license tag on a file is worse
than not having any tag at all.
BE VERY CAREFUL ABOUT THESE THINGS, they matter. If you get them wrong,
lawyers get very grumpy :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-23 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-23 11:11 [PATCH] net: ax25: Add SPDX License to fix missing License warning Jules Irenge
2019-02-23 12:58 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).