From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AACDC4360F for ; Sat, 23 Feb 2019 21:09:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 327C22086C for ; Sat, 23 Feb 2019 21:09:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550956154; bh=gZV3GHvESRAXzBe3tWoNbJ+iiA0e/U+GNPe9WZ8b0zY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=cCHfh6DAEiPllCE8iwZs/3j8POYcomIYK+Jjd9YjLDBAcxY3oZsxIquw4h0FZHjbJ 3DIcfJ2k7/mrFmyWEl4RNjQ/qG43JXzt7pg8wvvt9L0RIy9FzKkUr69S5pehGvGAtd /uxRT1x7sg6/Wu7hS+B77tItt3Ye55yuSUHn2fHU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729450AbfBWVJM (ORCPT ); Sat, 23 Feb 2019 16:09:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:44668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728761AbfBWVJJ (ORCPT ); Sat, 23 Feb 2019 16:09:09 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A9B0820855; Sat, 23 Feb 2019 21:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550956148; bh=gZV3GHvESRAXzBe3tWoNbJ+iiA0e/U+GNPe9WZ8b0zY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GyOdv/SZ/uPbUIqJrdEm51R1jXKBVuKuFc/kIvLvHpQ2GsnI6gwvLukHrIa9l/KDl aydBRfxvVjNtXm1OF1Se1RUQJyQ0zlGAWyksXP1w6SRiACiERfL03uLZydxkpgDtpN ZEsxEjS7RljfArrupvhXFLmEh8G2xQ1OsbSeu9BY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yonglong Liu , Peng Li , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 18/45] net: hns: Restart autoneg need return failed when autoneg off Date: Sat, 23 Feb 2019 16:08:08 -0500 Message-Id: <20190223210835.201708-18-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190223210835.201708-1-sashal@kernel.org> References: <20190223210835.201708-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Yonglong Liu [ Upstream commit ed29ca8b9592562559c64d027fb5eb126e463e2c ] The hns driver of earlier devices, when autoneg off, restart autoneg will return -EINVAL, so make the hns driver for the latest devices do the same. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c index c1e947bb852ff..14df03f60e059 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c @@ -1154,16 +1154,18 @@ static int hns_get_regs_len(struct net_device *net_dev) */ static int hns_nic_nway_reset(struct net_device *netdev) { - int ret = 0; struct phy_device *phy = netdev->phydev; - if (netif_running(netdev)) { - /* if autoneg is disabled, don't restart auto-negotiation */ - if (phy && phy->autoneg == AUTONEG_ENABLE) - ret = genphy_restart_aneg(phy); - } + if (!netif_running(netdev)) + return 0; - return ret; + if (!phy) + return -EOPNOTSUPP; + + if (phy->autoneg != AUTONEG_ENABLE) + return -EINVAL; + + return genphy_restart_aneg(phy); } static u32 -- 2.19.1