From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 670A9C4360F for ; Sat, 23 Feb 2019 21:14:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A04120651 for ; Sat, 23 Feb 2019 21:14:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550956465; bh=bjp8Tj777Js8Bx2blSJSQgtiebBrsnYBplQph8HUHmM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Ag/eIy0fKKFt7KlEDaBlKsxa5PoVdxYJj+ovVUMploNcFzTiwfPwVOE+DBUQpa4wO U9BQ8h09FpzdpOPEOuQbZXVSVbbyaTDbWV1s7DIPocyIMF0NZ5btGNRCuwJSL5tpuN 9i/yHjxt/dEIkjWomAM33d1T6NRaBdsuhnX1gsJs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729932AbfBWVLO (ORCPT ); Sat, 23 Feb 2019 16:11:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:47568 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729918AbfBWVLM (ORCPT ); Sat, 23 Feb 2019 16:11:12 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 363F62085A; Sat, 23 Feb 2019 21:11:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550956272; bh=bjp8Tj777Js8Bx2blSJSQgtiebBrsnYBplQph8HUHmM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PZJIFUBj+BUJ26WSBxGmUV6xlQNqxGhR7EXJllrLzsLxn5KyJmJaiMhK1R2o+P76Z XGppMdwbBJnG/MIEIsJBDwEFVz6NFV5wVyB1zMAfoO+v5TPCuOyp1Qvh3ecdNZAa/S D5WOB7XenHlM8Up9Ie+fYsR2Ppti7WRUqWAEsd/4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alexey Khoroshilov , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 14/26] net: stmmac: dwmac-rk: fix error handling in rk_gmac_powerup() Date: Sat, 23 Feb 2019 16:10:35 -0500 Message-Id: <20190223211047.202725-14-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190223211047.202725-1-sashal@kernel.org> References: <20190223211047.202725-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Alexey Khoroshilov [ Upstream commit c69c29a1a0a8f68cd87e98ba4a5a79fb8ef2a58c ] If phy_power_on() fails in rk_gmac_powerup(), clocks are left enabled. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c index 0cd3ecff768b3..398b08e07149b 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -535,8 +535,10 @@ static int rk_gmac_init(struct platform_device *pdev, void *priv) int ret; ret = phy_power_on(bsp_priv, true); - if (ret) + if (ret) { + gmac_clk_enable(bsp_priv, false); return ret; + } ret = gmac_clk_enable(bsp_priv, true); if (ret) -- 2.19.1