From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A3AC43381 for ; Mon, 25 Feb 2019 01:31:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90FD621019 for ; Mon, 25 Feb 2019 01:31:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728311AbfBYBbV (ORCPT ); Sun, 24 Feb 2019 20:31:21 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:33418 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726511AbfBYBbU (ORCPT ); Sun, 24 Feb 2019 20:31:20 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D278A14D644E4; Sun, 24 Feb 2019 17:31:19 -0800 (PST) Date: Sun, 24 Feb 2019 17:31:13 -0800 (PST) Message-Id: <20190224.173113.480240248994038722.davem@davemloft.net> To: dcaratti@redhat.com Cc: vladbu@mellanox.com, xiyou.wangcong@gmail.com, jhs@mojatatu.com, jiri@resnulli.us, netdev@vger.kernel.org Subject: Re: [PATCH net] net/sched: act_ipt: fix refcount leak when replace fails From: David Miller In-Reply-To: <9616212b5203dac35d55d67b25963487a8276191.1550834953.git.dcaratti@redhat.com> References: <9616212b5203dac35d55d67b25963487a8276191.1550834953.git.dcaratti@redhat.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 24 Feb 2019 17:31:20 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Davide Caratti Date: Fri, 22 Feb 2019 12:33:25 +0100 > After commit 4e8ddd7f1758 ("net: sched: don't release reference on action > overwrite"), the error path of all actions was converted to drop refcount > also when the action was being overwritten. But we forgot act_ipt_init(), > in case allocation of 'tname' was not successful: > > # tc action add action xt -j LOG --log-prefix hello index 100 > tablename: mangle hook: NF_IP_POST_ROUTING > target: LOG level warning prefix "hello" index 100 > # tc action show action xt > total acts 1 > > action order 0: tablename: mangle hook: NF_IP_POST_ROUTING > target LOG level warning prefix "hello" > index 100 ref 1 bind 0 > # tc action replace action xt -j LOG --log-prefix world index 100 > tablename: mangle hook: NF_IP_POST_ROUTING > target: LOG level warning prefix "world" index 100 > RTNETLINK answers: Cannot allocate memory > We have an error talking to the kernel > # tc action show action xt > total acts 1 > > action order 0: tablename: mangle hook: NF_IP_POST_ROUTING > target LOG level warning prefix "hello" > index 100 ref 2 bind 0 > > Ensure we call tcf_idr_release(), in case 'tname' allocation failed, also > when the action is being replaced. > > Fixes: 4e8ddd7f1758 ("net: sched: don't release reference on action overwrite") > Signed-off-by: Davide Caratti Applied and queued up for -stable.