From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AABFC43381 for ; Mon, 25 Feb 2019 01:43:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E39402087C for ; Mon, 25 Feb 2019 01:43:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728337AbfBYBni (ORCPT ); Sun, 24 Feb 2019 20:43:38 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:33570 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726511AbfBYBni (ORCPT ); Sun, 24 Feb 2019 20:43:38 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 46BDD14D68D51; Sun, 24 Feb 2019 17:43:38 -0800 (PST) Date: Sun, 24 Feb 2019 17:43:37 -0800 (PST) Message-Id: <20190224.174337.1452333811738028062.davem@davemloft.net> To: hkallweit1@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: phy: check PMAPMD link status only in genphy_c45_read_link From: David Miller In-Reply-To: <9c7b68ea-ac30-a7ec-1c88-ae819dbbb7b4@gmail.com> References: <9c7b68ea-ac30-a7ec-1c88-ae819dbbb7b4@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 24 Feb 2019 17:43:38 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Fri, 22 Feb 2019 22:59:38 +0100 > The current code reports a link as up if all devices (except a few > blacklisted ones) report the link as up. This breaks Aquantia AQCS109 > for lower speeds because on this PHY the PCS link status reflects a > 10G link only. For Marvell there's a similar issue, therefore PHYXS > device isn't checked. > > There may be more PHYs where depending on the mode the link status > of only selected devices is relevant. > > For now it seems to be sufficient to check the link status of the > PMAPMD device only. Leave the loop in the code to be prepared in > case we have to add functionality to check more than one device, > depending on the mode. > > Successfully tested on a board with an AQCS109. > > Signed-off-by: Heiner Kallweit Applied.