From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73EB4C43381 for ; Mon, 25 Feb 2019 06:25:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CB732084D for ; Mon, 25 Feb 2019 06:25:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726797AbfBYGZo (ORCPT ); Mon, 25 Feb 2019 01:25:44 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:35776 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726401AbfBYGZo (ORCPT ); Mon, 25 Feb 2019 01:25:44 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 888C414E06F72; Sun, 24 Feb 2019 22:25:43 -0800 (PST) Date: Sun, 24 Feb 2019 22:25:43 -0800 (PST) Message-Id: <20190224.222543.774089403248163510.davem@davemloft.net> To: posk@google.com Cc: netdev@vger.kernel.org, posk@posk.io Subject: Re: [PATCH net-next] net: fix double-free in bpf_lwt_xmit_reroute From: David Miller In-Reply-To: <20190224022501.71889-1-posk@google.com> References: <20190224022501.71889-1-posk@google.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 24 Feb 2019 22:25:43 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Peter Oskolkov Date: Sat, 23 Feb 2019 18:25:01 -0800 > dst_output() frees skb when it fails (see, for example, > ip_finish_output2), so it must not be freed in this case. > > Fixes: 3bd0b15281af ("bpf: add handling of BPF_LWT_REROUTE to lwt_bpf.c") > Signed-off-by: Peter Oskolkov Applied.