From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C9C6C43381 for ; Sun, 24 Feb 2019 06:46:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D4A1D204EC for ; Sun, 24 Feb 2019 06:46:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="Hgz5c8rp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728160AbfBXGqy (ORCPT ); Sun, 24 Feb 2019 01:46:54 -0500 Received: from mail-eopbgr80082.outbound.protection.outlook.com ([40.107.8.82]:37246 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728138AbfBXGqv (ORCPT ); Sun, 24 Feb 2019 01:46:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e6vERckIHJWWYnfC4yMlE4VhaUM/uPwDPx2CrhRH3sQ=; b=Hgz5c8rp0A9seVgMbBsuxAqcPi54rhuw4fL8GoCs/85+bjhhaE8KsJx1OOPOpDtiRWcwol/KI5Zz8j2r+UTHeFvZyjpLr+obkSQ3h65y+diPxjxXyiFuz9MxsRoCLbA8FnIIn0gKva4PvUFTaUNqXFWOn0R1F+sMQZiRpIiglH8= Received: from AM6PR05MB5240.eurprd05.prod.outlook.com (20.177.196.214) by AM6PR05MB4343.eurprd05.prod.outlook.com (52.135.162.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.18; Sun, 24 Feb 2019 06:46:34 +0000 Received: from AM6PR05MB5240.eurprd05.prod.outlook.com ([fe80::3542:889c:3a85:3866]) by AM6PR05MB5240.eurprd05.prod.outlook.com ([fe80::3542:889c:3a85:3866%5]) with mapi id 15.20.1643.019; Sun, 24 Feb 2019 06:46:34 +0000 From: Ido Schimmel To: "netdev@vger.kernel.org" CC: "davem@davemloft.net" , Jiri Pirko , mlxsw , Ido Schimmel Subject: [PATCH net-next 10/15] mlxsw: spectrum_acl: Remove RTNL lock assertions from ERP code Thread-Topic: [PATCH net-next 10/15] mlxsw: spectrum_acl: Remove RTNL lock assertions from ERP code Thread-Index: AQHUzAysF4/KlP9LhUy06A+BM39FeA== Date: Sun, 24 Feb 2019 06:46:30 +0000 Message-ID: <20190224064525.14913-11-idosch@mellanox.com> References: <20190224064525.14913-1-idosch@mellanox.com> In-Reply-To: <20190224064525.14913-1-idosch@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6P194CA0033.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::46) To AM6PR05MB5240.eurprd05.prod.outlook.com (2603:10a6:20b:64::22) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 49b49361-8e84-4d2f-c1f7-08d69a23cec5 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600110)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:AM6PR05MB4343; x-ms-traffictypediagnostic: AM6PR05MB4343: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1;AM6PR05MB4343;23:QkUsiFcQB5qqn6GHp67zb+9gXHNCVSklnBvt9hS?= =?iso-8859-1?Q?vHsLD7qqilpqZ+R8dySBpsS/3i7t/DPnctRlH/aFuyiWKXWRluRU9Czeom?= =?iso-8859-1?Q?or6R1qeUTUtGMKIeLsMcfI89GzLmTh9gB+tcLyAlFiql3o+EdsYmHQLjYe?= =?iso-8859-1?Q?PEMIVlwG7jpwg0fDbZ49p5gK0ASsVHqseidpF52RMfiNBKXMXgcTVHBhsk?= =?iso-8859-1?Q?eLF+JXpMyX4PQ0qqAemi4LkawqoSFqnOjdosETptyehVur83BlR6m3oEXZ?= =?iso-8859-1?Q?cextwDgOUPVbbThyAP0fjNkSDL3FHKfSTwZo+P2Gxuigvl1a7Ei20eIR79?= =?iso-8859-1?Q?VxhtMbDVyRBThSs9GpX/UmpX5x/fOTllzJhupqCQ0H0HZDmfL43vxpon3g?= =?iso-8859-1?Q?DEhlRPUO8l1ZAeT6zi721LqxywpKJayCV1z4UbCraKgf9U2Urydxeff1n/?= =?iso-8859-1?Q?e4rql7vAxjgrf9TdtkNrvuvw+7gFyJlmC0L06N200BL5kgJzDUZitnBDm7?= =?iso-8859-1?Q?C5e/rSL8d/9v6uBO6L9fPk5XNLpRgxh0inHHY9iRjPbUAZRGR1xvYsO+VT?= =?iso-8859-1?Q?ot3ATsgLaIV62+n/kPqIkMPFLU7UPpEhIVsA6LCSi/DILT5Vrom6AHsTjs?= =?iso-8859-1?Q?KpOYWyrZR+mhFVmH9brKHiELyt0zr1vJLIIhjgwi0rnOKIl9vJ6u/AYy7g?= =?iso-8859-1?Q?rBR5YmjqpNaJX6svbaMCbnHAwjCzhSQwiwyEyv0UhE6H3mEtiQG0/adTeh?= =?iso-8859-1?Q?UkP2yBuoWCl9ZToO6cyjmBKVDzwtksqWMhHPowGRIgWlL+Hc9zFnOY0Ui4?= =?iso-8859-1?Q?k3Y602soOB/0D+OQvzvqiF/UGCyS+/puv6P+ra1KouTkrDG2WRQgsLqtw1?= =?iso-8859-1?Q?KLaSVBSg7IyyjUGXMKq3KOUAXhV2CqYGVf+SyPKV8455ZH0NC8BiI5UnBB?= =?iso-8859-1?Q?G+HfxLjsW63c1jBwiWwq/6SPl6PoX2eIKm0rTJoWxUi9W7vJOvyNMvqtoD?= =?iso-8859-1?Q?IQ3nZJ/zJ/SLrViIchxFlErUBvK2xJw50B0SRo4QulHB4K5SKZHc16bGj4?= =?iso-8859-1?Q?KHM33YzQO69oWcAMtjmbbz7aoZj5NWXgTk/9w9jm5C9ssH89UYYobi6pw6?= =?iso-8859-1?Q?PhAi49eA9s99iWsNRQg9R7Me6DAsP8aCPCVn9E691YNkYsZPM4wbh/Dbmh?= =?iso-8859-1?Q?YwSY8t6RaP5kXAwwyIrG69dfFGOC/I4KN2kVId+RIIH/cfSZ4uYT2//keT?= =?iso-8859-1?Q?8lH2k+vUtDtrnKdCimni0gWJLlx8QbGtnKspKKhMiTmllCR40whSkGQ6aN?= =?iso-8859-1?Q?x+UNs1QSQmM8TmyXa1yTyIE2qKtcfkCnnjMttQnekBp3wh7yA+CloM8PLn?= =?iso-8859-1?Q?WLMAXYLGeYdBRw3dFncMSs5rJf8IJWe2z4S3BoSJs9f6bvf1ZA+JmPxriU?= =?iso-8859-1?Q?ABzeHVQeI43ba4nTEGYRoAG32yGfPTdvNi5?= x-microsoft-antispam-prvs: x-forefront-prvs: 09583628E0 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(396003)(136003)(376002)(346002)(39850400004)(43544003)(199004)(189003)(102836004)(5660300002)(3846002)(14444005)(8936002)(6116002)(5640700003)(256004)(6666004)(6506007)(386003)(1076003)(71200400001)(71190400001)(14454004)(6512007)(6436002)(81166006)(2351001)(81156014)(1730700003)(6346003)(50226002)(26005)(6916009)(107886003)(2906002)(99286004)(86362001)(2501003)(486006)(2616005)(4326008)(11346002)(54906003)(66066001)(316002)(476003)(446003)(53936002)(68736007)(52116002)(7736002)(6486002)(8676002)(478600001)(106356001)(305945005)(105586002)(25786009)(186003)(36756003)(76176011)(97736004);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR05MB4343;H:AM6PR05MB5240.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 7oRLTHBmTFeALm8riiN3OhM4FTQWV/mE8hDJajg+fEVNJgRS5SaDeNcqoeYmYCITVssoaXrEVYTvj4Y4NF9xn/y6QBFaSjPxiiPptrvH7PXM4Usd5SCYM/ngZIj54vbWwhuV7XD+KfkxJN5EP0l6TjW6+2XTgoSi5LjsfzHsRi76mJ743NbkaCEDM8H2u10IuqgyRoYOugel0UqQPwtruGpdHoXAla8ErNDS/I5/cribdwQ25b5vqt/l7vOzXwx4AlYeqUti310IIH2MzLS7ZLNhCoiY6KMEbTReJ3Js7gD/q/APOA8X3he7hiLI0ZTl2I9Q4rAQEHjvWAxhhVZhXDpjM/fM4lNUeejSqws/fxOk8lHptrUmgjlirBGTnxijfVI1JWRPxICB6iRmOYlvCFgOU4GJ7pbogE/zLx4z9ik= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49b49361-8e84-4d2f-c1f7-08d69a23cec5 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2019 06:46:29.8520 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB4343 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko No longer require RTNL lock in this code. Newly introduced mutexes take care of guarding objagg and bloom filter. There is no need to guard gen_pool_alloc()/gen_pool_free() as they are fine to be called lockless. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_erp.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_erp.c b/drive= rs/net/ethernet/mellanox/mlxsw/spectrum_acl_erp.c index d6961dd0c556..c1a9cc9a3292 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_erp.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_erp.c @@ -1007,11 +1007,6 @@ mlxsw_sp_acl_erp_mask_get(struct mlxsw_sp_acl_atcam_= region *aregion, struct mlxsw_sp_acl_erp_key key; struct objagg_obj *objagg_obj; =20 - /* eRPs are allocated from a shared resource, but currently all - * allocations are done under RTNL. - */ - ASSERT_RTNL(); - memcpy(key.mask, mask, MLXSW_REG_PTCEX_FLEX_KEY_BLOCKS_LEN); key.ctcam =3D ctcam; mutex_lock(&erp_table->objagg_lock); @@ -1042,7 +1037,6 @@ int mlxsw_sp_acl_erp_bf_insert(struct mlxsw_sp *mlxsw= _sp, const struct mlxsw_sp_acl_erp *erp =3D objagg_obj_root_priv(objagg_obj); unsigned int erp_bank; =20 - ASSERT_RTNL(); if (!mlxsw_sp_acl_erp_table_is_used(erp->erp_table)) return 0; =20 --=20 2.20.1