From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61CEBC43381 for ; Sun, 24 Feb 2019 06:46:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 242A3204EC for ; Sun, 24 Feb 2019 06:46:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="ZKYM4o6I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728178AbfBXGq5 (ORCPT ); Sun, 24 Feb 2019 01:46:57 -0500 Received: from mail-eopbgr40071.outbound.protection.outlook.com ([40.107.4.71]:39872 "EHLO EUR03-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726459AbfBXGqx (ORCPT ); Sun, 24 Feb 2019 01:46:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IDLcuQMsDGjQcH8FlHfFEc7QKqoIcjnHY9ZbTRrm8Ro=; b=ZKYM4o6IMELh5ON3CHHa4QSjp4Zi0QrM55S6r8ZaIFwLKhQf8N7+MCv1AtJTI1bmu4OLCoTAW7mADAYK+48Ld2WAqjVdkhK1UBLD9V1UTs914Ij3/FcsPBEhsZVQZLtpmVevpz19KaIO1ERD2E/49QxvxA0JZC5QtGuj6a34JxU= Received: from AM6PR05MB5240.eurprd05.prod.outlook.com (20.177.196.214) by AM6PR05MB4343.eurprd05.prod.outlook.com (52.135.162.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.18; Sun, 24 Feb 2019 06:46:35 +0000 Received: from AM6PR05MB5240.eurprd05.prod.outlook.com ([fe80::3542:889c:3a85:3866]) by AM6PR05MB5240.eurprd05.prod.outlook.com ([fe80::3542:889c:3a85:3866%5]) with mapi id 15.20.1643.019; Sun, 24 Feb 2019 06:46:35 +0000 From: Ido Schimmel To: "netdev@vger.kernel.org" CC: "davem@davemloft.net" , Jiri Pirko , mlxsw , Ido Schimmel Subject: [PATCH net-next 11/15] mlxsw: spectrum_acl: Don't take mutex in mlxsw_sp_acl_tcam_vregion_rehash_work() Thread-Topic: [PATCH net-next 11/15] mlxsw: spectrum_acl: Don't take mutex in mlxsw_sp_acl_tcam_vregion_rehash_work() Thread-Index: AQHUzAyslahOrjI4FUmba3RML9IKsA== Date: Sun, 24 Feb 2019 06:46:31 +0000 Message-ID: <20190224064525.14913-12-idosch@mellanox.com> References: <20190224064525.14913-1-idosch@mellanox.com> In-Reply-To: <20190224064525.14913-1-idosch@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6P194CA0033.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::46) To AM6PR05MB5240.eurprd05.prod.outlook.com (2603:10a6:20b:64::22) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e582b5b3-c6ef-4e92-0f9b-08d69a23cf4b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600110)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:AM6PR05MB4343; x-ms-traffictypediagnostic: AM6PR05MB4343: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1;AM6PR05MB4343;23:3nsoma5GPpLHzFpQUPk0lYOW0KGLaV72rW9w7t0?= =?iso-8859-1?Q?UO7yi1c/RDRtm7pj70EIC/QLwD83AGh/OpWl5lKuI26WpUM8aITPNwrMYk?= =?iso-8859-1?Q?vciQ2UuLCIYgWclejYzxN6DZmHTcxuB7yiszAgiPzTV/mXRjmKHs0xpTXT?= =?iso-8859-1?Q?8rI7wSTYe+AGI6lKyil8rgdV5N+ezMenzLE1kCWPr9huZFqLJHNf4v2Xwr?= =?iso-8859-1?Q?SZGRuqZvvaQLeMJ/EN+Zt4F0Eae0cNDMTqK6apsJCrLhZcGMVlr6VaVrXt?= =?iso-8859-1?Q?jsWZ0vf6l6y1wOlupxcGZ3o6epeK+DqcA6/dynlKBAzMMBnE7maTHtaRq4?= =?iso-8859-1?Q?L22EYUFJXQZ52VFGKhttE9JRPv2ods0hFkTFAJLNvPIwjSMQpUoOASA0jx?= =?iso-8859-1?Q?kYH0IAzGviLtnLvP3MFKdQkbZ82t4+2d8czyMSYT4/PqaIoUXULdWEMtJZ?= =?iso-8859-1?Q?NaRsXcFQjvcRiPcZWyetBpn0NeEzABuPyMJA917J71f7iDyFoSCqko4QnI?= =?iso-8859-1?Q?4KcB1LrWCmMx1+x/dQT/lzEnXR88WZISf7Lnvxw2q8gfvB947wotgI4nHr?= =?iso-8859-1?Q?Xqg7q9hYuDlmp+VNT5qnWEMaqBeLdy37/9vsRNx+G8OWky4BhThP6O8qlH?= =?iso-8859-1?Q?VkPyGoRUKzUiXeekrLQTdicG/A61cwtNFD3OqfpZ93fcRfqw2zOzAUXYh+?= =?iso-8859-1?Q?SheHc0KFodY1w1qVIomIs7+wPCqDj/DzZ60NIx6oL1CZgSUJ1WitFSyWTS?= =?iso-8859-1?Q?k1Bj4s22XHdSPrYko1dnTeCuaPQx1qiuW23wMP1f7F2n8I5yBrU/8mdkxC?= =?iso-8859-1?Q?gETww/tbt4QCdkckmLHYngiV/RQeIPUNFg1Y+AzusCGLQ/qK4yQYXbWpLY?= =?iso-8859-1?Q?enS1KGbT25/jqioisp09iZAPbxTp9MwtqUsCpWEfQBS1rfW0l/m4/f1vpt?= =?iso-8859-1?Q?6elGKtLOIuIjD2RIzNfkC5LHbDz//U18As6gN3xPhENgQpIP/XPdDIid3o?= =?iso-8859-1?Q?4DvQBVgEmnDTg3VZmQ8h5IH0QZbjC9qJxJzYNUwk3qXrgZgC+sGRlHVkva?= =?iso-8859-1?Q?fyCkO3bN4+Zv1p3F5OhCjv3AGcvZ7eHLoep3/wnElAXVPYbM6j9qwWcdYQ?= =?iso-8859-1?Q?VfY3PWNJqkuB9hKxLBnSBUUWZzpw0X4HjZv1ek7GWq+5Ss9Cwk/MPtRwue?= =?iso-8859-1?Q?H6Uj9aGO+Tesitr6o8Dv04prkcNZEga88iSzZuj5gXCfiizmnoxnGqYu9O?= =?iso-8859-1?Q?DIfUcOcfLgZfqbLkU7NTY/yc0wPXOGYYwj5OUzteux0vy30CRUhAZXZNbQ?= =?iso-8859-1?Q?tKbUFBB/ASA5ks3GLn1J34oDPphMuewJNn5eggq+Bbo8LOvmnu3mUoGrDp?= =?iso-8859-1?Q?kGzNSav8BtXglkbIgXoxpRJQyOEwED4FA88Lza6HNNWfRk8WBMxhh99Jlg?= =?iso-8859-1?Q?P5lyNSoJrcey0tMVtWyGLzyP35PjvLGZ6HH8yolk6bhRLrU+AcqfXHZys2?= =?iso-8859-1?Q?aHwTFsFfA6lSAu8fS0ED//u6iKq5RS7bGqtcdn+iq?= x-microsoft-antispam-prvs: x-forefront-prvs: 09583628E0 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(979002)(366004)(396003)(136003)(376002)(346002)(39850400004)(199004)(189003)(102836004)(5660300002)(3846002)(14444005)(8936002)(6116002)(5640700003)(256004)(6666004)(6506007)(386003)(1076003)(71200400001)(71190400001)(14454004)(6512007)(6436002)(81166006)(2351001)(81156014)(1730700003)(6346003)(50226002)(26005)(6916009)(107886003)(2906002)(99286004)(86362001)(2501003)(486006)(2616005)(4326008)(11346002)(54906003)(66066001)(316002)(476003)(446003)(53936002)(68736007)(52116002)(7736002)(6486002)(8676002)(478600001)(106356001)(305945005)(105586002)(25786009)(186003)(36756003)(76176011)(97736004)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR05MB4343;H:AM6PR05MB5240.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: cGymiUMp8mHI7SPphy3usezfeKDroP3iWmdLSas1X6Z+lzGPDha9LpopSuqpEro2D2srNNlrfmsZlInFKtkI/4dJWUVjBtmJ1mibf4Jh+Te5ydtTC6DWBoVRGrR+QNmkskDnjQa/aXVGDcf81emd3GNYEYDvWLmat1PuMyFf9+6CkUO861RJzI3poR/bczFpmDiBTNwubL2z+ufuOo4bupIKHKKh6QMOU3juVmrX5zOqMgBj3WpfAbZVP41C3cq4Bzg4rV2K64JYOw/bfsQHuMXhAPbSILTwWLn0DzWUDm9Mt+92GV1lJCMN8zhR+/M7q/hXhqQC83TVWPImBtPsVSamfwIpkd0fMslQ/30P+r5VOmzMR0Z+LXf7aIzzXki7HPAJ8hn9RskXrEzKo9fGJCUuwM/7NRu8X5j13no9OUs= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: e582b5b3-c6ef-4e92-0f9b-08d69a23cf4b X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2019 06:46:30.7296 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB4343 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Other mutexes are taking care of proper locking for this, no longer needed to take RTNL mutex here. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c b/driv= ers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c index 5c8976e471ad..822766f81236 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c @@ -732,12 +732,7 @@ static void mlxsw_sp_acl_tcam_vregion_rehash_work(stru= ct work_struct *work) container_of(work, struct mlxsw_sp_acl_tcam_vregion, rehash_dw.work); =20 - /* TODO: Take rtnl lock here as the rest of the code counts on it - * now. Later, this should be replaced by per-vregion lock. - */ - rtnl_lock(); mlxsw_sp_acl_tcam_vregion_rehash(vregion->mlxsw_sp, vregion); - rtnl_unlock(); mlxsw_sp_acl_tcam_vregion_rehash_work_schedule(vregion); } =20 --=20 2.20.1