From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E108C00319 for ; Sun, 24 Feb 2019 10:56:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F504206B6 for ; Sun, 24 Feb 2019 10:56:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="YIxE8cKt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728046AbfBXK40 (ORCPT ); Sun, 24 Feb 2019 05:56:26 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:37792 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725920AbfBXK40 (ORCPT ); Sun, 24 Feb 2019 05:56:26 -0500 Received: by mail-wr1-f68.google.com with SMTP id w6so3558060wrs.4 for ; Sun, 24 Feb 2019 02:56:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6Pit47+sxHNiaWDSMZUxCWwnTxtJGx345S5VeL8UaL4=; b=YIxE8cKtCWkqzs4Uu25Wq+W78jF6kvZ11fH8S9EaOyAJzSAM6PbjGzMKD9O7ggpLip +3R/HIAH8xpygNUynKaGPGJUL4EqOb8Jy5XtEbD2JGhSCHDqq99G4iKTJGwcfiO2IQxl eLprcHm/0XFTre9zybnBQEizEKJCGITy00SXmt4xf8mgXH5OUxviPD1t2SPFIgFWNB/h u8WhGIjuIULWn9V0d0iRlkXOYwfdph73emoU3KMBE8/eRdAsRTKjJDq5K4MiTGODs9jM 5b7/Fcst6FWrR+/9YkjqSJWRU+zERvfaMxnPYKAq0IUOGREOS5DU6oGVkJK9nKNf6ufV ItrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6Pit47+sxHNiaWDSMZUxCWwnTxtJGx345S5VeL8UaL4=; b=pEtbQUOZlYc9qbWC+/BtEj33OBbUCbxOgwI0j5TeZF+Z1iprX4XR8W2ETs90JQIdCW ZakSeCCRLuOa/yy0m+AyXX5fE/SX4587MLeSXIyI9X6mIMzcbtOgPfOaLavjXnmEsMCh /ORGZyj43KXw0ULGXGmETTLWJ8p3F9bkmLM4JEHA67dC/bqWfoyEaWWNL27O94tOTmfG lMWNys1Yq3nk6ROw2YUplpyKaeH/19oQJ2Tn3sPl2ZcwNg+1MEuwfy3DGOvkZQMB8Zhe mjir4t5X/TJnsoE8UopyhcZ1UH3V6QUjNwPTzNgVFj2d2bG+jrCqs7vlS8V3AworXQQi RHZg== X-Gm-Message-State: AHQUAuZorJFnxBeHivydepSfsO3EHGTghgWTMBRm5g4NDDkE5hmHgTQh rMhvDnvgyoJmk8sk5Qx1XGntqQ== X-Google-Smtp-Source: AHgI3IaZEntVel3O7wNBKj0qr+3F40KcX7TIl6bmVXqiqr9ORuJOwE25mKHIYnGqGdvLTLL1kq+r0g== X-Received: by 2002:adf:fecd:: with SMTP id q13mr8971195wrs.3.1551005784062; Sun, 24 Feb 2019 02:56:24 -0800 (PST) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id c2sm7217335wrt.93.2019.02.24.02.56.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Feb 2019 02:56:23 -0800 (PST) Date: Sun, 24 Feb 2019 11:46:43 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, mkubecek@suse.cz, andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next v3 1/6] net: devlink: turn devlink into a built-in Message-ID: <20190224104643.GE2759@nanopsycho.orion> References: <20190222220758.7117-1-jakub.kicinski@netronome.com> <20190222220758.7117-2-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190222220758.7117-2-jakub.kicinski@netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fri, Feb 22, 2019 at 11:07:52PM CET, jakub.kicinski@netronome.com wrote: >Being able to build devlink as a module causes growing pains. >First all drivers had to add a meta dependency to make sure >they are not built in when devlink is built as a module. Now >we are struggling to invoke ethtool compat code reliably. > >Make devlink code built-in, users can still not build it at >all but the dynamically loadable module option is removed. > >Signed-off-by: Jakub Kicinski >Reviewed-by: Florian Fainelli Acked-by: Jiri Pirko