From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: No traffic with Marvell switch and latest linux-next
Date: Sun, 24 Feb 2019 18:04:55 +0100 [thread overview]
Message-ID: <20190224170455.GH26626@lunn.ch> (raw)
In-Reply-To: <7005686d-45cb-a8af-de34-873c9e34a021@gmail.com>
> The added difficulty here and the reason why Andrew went with the
> approach that is used by the code currently is because neither do the
> CPU or DSA ports are backed by a net_device. It is somewhere on my TODO
> to permit the use of PHYLINK without the need of a net_device to cover
> those specific DSA cases unless we just brute force the whole thing and
> allocate a net_device structure but not register that net_device? Yes in
> fact, why don't we do that?
Hi Florian
At the moment, we are using a phydev which is not connected to a
MAC. That is rather odd, but the phylib maintainers mostly know about
this, and keep an eye out for changes which might break any
assumptions. And the phylib API is quite small.
How many assumptions are going to break with a netdev which is not
registered? The API is much bigger, more people hack on it, and it is
going to be much harder to review changes to make sure assumptions are
not changed.
If we are going to do something odd, we should keep the scope as small
as possible.
Andrew
next prev parent reply other threads:[~2019-02-24 17:04 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-17 15:34 No traffic with Marvell switch and latest linux-next Heiner Kallweit
2019-02-17 15:40 ` Russell King - ARM Linux admin
2019-02-17 15:50 ` Heiner Kallweit
2019-02-17 16:40 ` Heiner Kallweit
2019-02-17 16:57 ` Andrew Lunn
2019-02-17 17:06 ` Heiner Kallweit
2019-02-17 17:10 ` Andrew Lunn
2019-02-18 18:16 ` Heiner Kallweit
2019-02-18 18:21 ` Andrew Lunn
2019-02-23 21:48 ` Heiner Kallweit
2019-02-23 23:42 ` Andrew Lunn
2019-02-24 9:10 ` Heiner Kallweit
2019-02-24 15:04 ` Andrew Lunn
2019-02-24 15:15 ` Russell King - ARM Linux admin
2019-02-24 15:28 ` Heiner Kallweit
2019-02-24 15:34 ` Russell King - ARM Linux admin
2019-02-24 15:39 ` Heiner Kallweit
2019-02-24 15:49 ` Russell King - ARM Linux admin
2019-02-24 16:32 ` Florian Fainelli
2019-02-24 17:04 ` Andrew Lunn [this message]
2019-02-24 21:26 ` Florian Fainelli
2019-02-24 21:42 ` Heiner Kallweit
2019-02-24 15:31 ` Russell King - ARM Linux admin
2019-02-24 17:28 ` Andrew Lunn
2019-02-24 19:41 ` Russell King - ARM Linux admin
2019-02-23 23:55 ` Florian Fainelli
2019-02-17 15:45 ` Andrew Lunn
2019-02-17 15:48 ` Heiner Kallweit
2019-02-17 15:57 ` Andrew Lunn
2019-02-17 16:01 ` Heiner Kallweit
2019-02-17 15:51 ` Andrew Lunn
2019-02-17 15:55 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190224170455.GH26626@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).