From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E9F6C43381 for ; Sun, 24 Feb 2019 17:04:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 048E720663 for ; Sun, 24 Feb 2019 17:04:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="e8TkNFl+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728458AbfBXRE5 (ORCPT ); Sun, 24 Feb 2019 12:04:57 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:36895 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728179AbfBXRE5 (ORCPT ); Sun, 24 Feb 2019 12:04:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2ybgViPMaWxf6FpeaYGy8p2Q9RctigLAm507LMy9dBs=; b=e8TkNFl+HG3yKy3Nbd8RrxrABb Px5M6kptEDZAfdJylH1zNdk95wAvDe+MzwHT6As1NHmJoIzJLvVRg/VjrzbDnsf0ZtRgQaovnp+fg qtEzzWIq2L8lsBdieYZrwXmSfQF/Ki70TBsaToFXPK1HYLgtnrb8A/Tiix2n5+Y65Lac=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gxxCx-0004Se-Mx; Sun, 24 Feb 2019 18:04:55 +0100 Date: Sun, 24 Feb 2019 18:04:55 +0100 From: Andrew Lunn To: Florian Fainelli Cc: Russell King - ARM Linux admin , Heiner Kallweit , "netdev@vger.kernel.org" Subject: Re: No traffic with Marvell switch and latest linux-next Message-ID: <20190224170455.GH26626@lunn.ch> References: <188fcef7-81fe-cffc-af71-1f37725b8611@gmail.com> <20190223234235.GA26626@lunn.ch> <6dd3f82a-eea0-c9b4-8dd6-f2f313578b1f@gmail.com> <20190224150403.GF26626@lunn.ch> <20190224151555.xsopwkuicsop65rw@shell.armlinux.org.uk> <403607a0-16d8-15b6-f0aa-b8b13793d401@gmail.com> <20190224153449.gg3c3fyryztdj3vm@shell.armlinux.org.uk> <20190224154900.jmjuh4uz2lvtankg@shell.armlinux.org.uk> <7005686d-45cb-a8af-de34-873c9e34a021@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7005686d-45cb-a8af-de34-873c9e34a021@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > The added difficulty here and the reason why Andrew went with the > approach that is used by the code currently is because neither do the > CPU or DSA ports are backed by a net_device. It is somewhere on my TODO > to permit the use of PHYLINK without the need of a net_device to cover > those specific DSA cases unless we just brute force the whole thing and > allocate a net_device structure but not register that net_device? Yes in > fact, why don't we do that? Hi Florian At the moment, we are using a phydev which is not connected to a MAC. That is rather odd, but the phylib maintainers mostly know about this, and keep an eye out for changes which might break any assumptions. And the phylib API is quite small. How many assumptions are going to break with a netdev which is not registered? The API is much bigger, more people hack on it, and it is going to be much harder to review changes to make sure assumptions are not changed. If we are going to do something odd, we should keep the scope as small as possible. Andrew