From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13757C43381 for ; Mon, 25 Feb 2019 18:18:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E68EA2084D for ; Mon, 25 Feb 2019 18:18:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728872AbfBYSSa (ORCPT ); Mon, 25 Feb 2019 13:18:30 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:43320 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728786AbfBYSSa (ORCPT ); Mon, 25 Feb 2019 13:18:30 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D877C14EE18D4; Mon, 25 Feb 2019 10:18:29 -0800 (PST) Date: Mon, 25 Feb 2019 10:18:29 -0800 (PST) Message-Id: <20190225.101829.46711684456598689.davem@davemloft.net> To: vladbu@mellanox.com Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us Subject: Re: [PATCH net-next] net: sched: set dedicated tcf_walker flag when tp is empty From: David Miller In-Reply-To: <20190225153831.10037-1-vladbu@mellanox.com> References: <20190225153831.10037-1-vladbu@mellanox.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 25 Feb 2019 10:18:30 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vlad Buslov Date: Mon, 25 Feb 2019 17:38:31 +0200 > Using tcf_walker->stop flag to determine when tcf_walker->fn() was called > at least once is unreliable. Some classifiers set 'stop' flag on error > before calling walker callback, other classifiers used to call it with NULL > filter pointer when empty. In order to prevent further regressions, extend > tcf_walker structure with dedicated 'nonempty' flag. Set this flag in > tcf_walker->fn() implementation that is used to check if classifier has > filters configured. > > Fixes: 8b64678e0af8 ("net: sched: refactor tp insert/delete for concurrent execution") > Signed-off-by: Vlad Buslov > Suggested-by: Cong Wang Applied, thanks.