From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CF71C43381 for ; Mon, 25 Feb 2019 22:21:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7E7F213A2 for ; Mon, 25 Feb 2019 22:21:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727586AbfBYWVS (ORCPT ); Mon, 25 Feb 2019 17:21:18 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:47098 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726845AbfBYWVS (ORCPT ); Mon, 25 Feb 2019 17:21:18 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 05E3614EF987A; Mon, 25 Feb 2019 14:21:17 -0800 (PST) Date: Mon, 25 Feb 2019 14:21:17 -0800 (PST) Message-Id: <20190225.142117.1223054756778786544.davem@davemloft.net> To: lesliemonis@gmail.com Cc: netdev@vger.kernel.org, tahiliani@nitk.edu.in, dave.taht@gmail.com, jhs@mojatatu.com Subject: Re: [PATCH net-next v3 0/7] net: sched: pie: align PIE implementation with RFC 8033 From: David Miller In-Reply-To: <20190225191001.26797-1-lesliemonis@gmail.com> References: <20190225191001.26797-1-lesliemonis@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 25 Feb 2019 14:21:18 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Leslie Monis Date: Tue, 26 Feb 2019 00:39:54 +0530 > The current implementation of the PIE queuing discipline is according to the > IETF draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and the paper > [PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem]. > However, a lot of necessary modifications and enhancements have been proposed > in RFC 8033, which have not yet been incorporated in the source code of Linux. > This patch series helps in achieving the same. > > Performance tests carried out using Flent [https://flent.org/] > > Changes from v2 to v3: > - Used div_u64() instead of direct division after explicit type casting as > recommended by David > > Changes from v1 to v2: > - Excluded the patch setting PIE dynamically active/inactive as the test > results were unsatisfactory > - Fixed a scaling issue when adding more auto-tuning cases which caused > local variables to underflow > - Changed the long if/else chain to a loop as suggested by Stephen > - Changed the position of the accu_prob variable in the pie_vars > structure as recommended by Stephen Series applied, thanks.