From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F6AC43381 for ; Mon, 25 Feb 2019 22:29:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D946B20643 for ; Mon, 25 Feb 2019 22:29:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728740AbfBYW3k (ORCPT ); Mon, 25 Feb 2019 17:29:40 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:47196 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727554AbfBYW3k (ORCPT ); Mon, 25 Feb 2019 17:29:40 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2254E14EFB583; Mon, 25 Feb 2019 14:29:40 -0800 (PST) Date: Mon, 25 Feb 2019 14:29:39 -0800 (PST) Message-Id: <20190225.142939.803768996918170563.davem@davemloft.net> To: xiyou.wangcong@gmail.com Cc: laoar.shao@gmail.com, daniel@iogearbox.net, edumazet@google.com, joe@perches.com, netdev@vger.kernel.org, shaoyafang@didiglobal.com Subject: Re: [PATCH v3 net-next 2/2] net: sock: undefine SOCK_DEBUGGING From: David Miller In-Reply-To: References: <20190223.183005.233475723803300804.davem@davemloft.net> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 25 Feb 2019 14:29:40 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Cong Wang Date: Mon, 25 Feb 2019 14:00:09 -0800 > Just to clarify, I have been suggesting to completely remove > this unused macro, never suggest to just undefine it in-tree. > > There is no reason to keep it in-tree, whether defined or undefined, > just for downstream users. And this is where you and I fundamentally disagree.