From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C0ADC43381 for ; Mon, 25 Feb 2019 04:02:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B8092084D for ; Mon, 25 Feb 2019 04:02:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="BlBzoaqt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728410AbfBYECJ (ORCPT ); Sun, 24 Feb 2019 23:02:09 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:37266 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726199AbfBYECJ (ORCPT ); Sun, 24 Feb 2019 23:02:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sUBSLdvkLWKT9qGfLcUqLIctew370e2pVUrB91iRFPo=; b=BlBzoaqtSYyIIpJLhjTjj87pAS 0KuL7qSwjc3shXB+yR9h1ZrA4srLUWnvHUqu6gQBwqulIgAL0d/OHTUjaDKBBwJ5/1cZfZhh6pyaV 5gXXGRNlp/FOpuXFVHgo7dkLFtJfwesCuDhMR6oB5YIVFTGDwVPDlrFoUo7vpLjD9OkI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gy7St-000092-B5; Mon, 25 Feb 2019 05:02:03 +0100 Date: Mon, 25 Feb 2019 05:02:03 +0100 From: Andrew Lunn To: Florian Fainelli Cc: Heiner Kallweit , David Miller , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next v2 2/2] net: phy: aquantia: add hwmon support Message-ID: <20190225040203.GF20855@lunn.ch> References: <2b46ac62-db6f-b72c-e81b-c6fbf063ab4b@gmail.com> <5e9c1d9f-4c9f-10fd-439e-26f7f2cc467e@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5e9c1d9f-4c9f-10fd-439e-26f7f2cc467e@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Feb 24, 2019 at 06:17:49PM -0800, Florian Fainelli wrote: > Le 2/24/19 à 1:36 PM, Heiner Kallweit a écrit : > > This adds HWMON support for the temperature sensor and the related > > alarms on the 107/108/109 chips. This patch is based on work from > > Nikita and Andrew. I added: > > - support for changing alarm thresholds via sysfs > > - move HWMON code to a separate source file to improve maintainability > > - smaller changes like using IS_REACHABLE instead of ifdef > > (avoids problems if PHY driver is built in and HWMON is a module) > > > > v2: > > - remove struct aqr_priv > > - rename header file to aquantia.h > > > > Signed-off-by: Nikita Yushchenko > > Should not Nikita be the author for that patch? Some minor nits below: > > > Signed-off-by: Andrew Lunn > > Signed-off-by: Heiner Kallweit Hi Florian The history is convoluted. I did the initial implementation, but at the time i did not have the hardware. So it got passed to Nikita who did. He made it actually work, and passed patches back. I then passed it onto Heiner who has done all the work on the driver and core for C45. Andrew