From: Sabrina Dubroca <sd@queasysnail.net>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Roopa Prabhu <roopa@cumulusnetworks.com>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH net] ipv4: Add ICMPv6 support when parse route ipproto
Date: Mon, 25 Feb 2019 12:14:39 +0100 [thread overview]
Message-ID: <20190225111439.GA26565@bistromath.localdomain> (raw)
In-Reply-To: <20190225074700.7316-1-liuhangbin@gmail.com>
2019-02-25, 15:47:00 +0800, Hangbin Liu wrote:
> @@ -14,6 +15,7 @@ int rtm_getroute_parse_ip_proto(struct nlattr *attr, u8 *ip_proto,
> case IPPROTO_TCP:
> case IPPROTO_UDP:
> case IPPROTO_ICMP:
> + case IPPROTO_ICMPV6:
Is IPPROTO_ICMPV6 supposed to be valid in the IPv4 code path calling
this function? inet_rtm_getroute_build_skb() doesn't seem to handle
it. Likewise, userspace could pass IPPROTO_ICMP from the IPv6 caller.
Also, should that be guarded by #if IS_ENABLED(CONFIG_IPV6) ?
> return 0;
> default:
> NL_SET_ERR_MSG(extack, "Unsupported ip proto");
> --
> 2.19.2
>
--
Sabrina
next prev parent reply other threads:[~2019-02-25 11:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 7:47 [PATCH net] ipv4: Add ICMPv6 support when parse route ipproto Hangbin Liu
2019-02-25 11:14 ` Sabrina Dubroca [this message]
2019-02-25 18:46 ` David Ahern
2019-02-26 2:17 ` Hangbin Liu
2019-02-26 2:23 ` David Ahern
2019-02-26 3:48 ` Hangbin Liu
2019-02-26 9:06 ` Sabrina Dubroca
2019-02-27 8:15 ` [PATCH v2 " Hangbin Liu
2019-03-02 0:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225111439.GA26565@bistromath.localdomain \
--to=sd@queasysnail.net \
--cc=davem@davemloft.net \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox