From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 688A0C43381 for ; Mon, 25 Feb 2019 12:33:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E27321734 for ; Mon, 25 Feb 2019 12:33:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726899AbfBYMdg (ORCPT ); Mon, 25 Feb 2019 07:33:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34890 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726475AbfBYMdg (ORCPT ); Mon, 25 Feb 2019 07:33:36 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 484C84E92A; Mon, 25 Feb 2019 12:33:36 +0000 (UTC) Received: from bistromath.localdomain (ovpn-204-202.brq.redhat.com [10.40.204.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DAA9960BF4; Mon, 25 Feb 2019 12:33:32 +0000 (UTC) Date: Mon, 25 Feb 2019 13:33:30 +0100 From: Sabrina Dubroca To: Paolo Abeni Cc: netdev@vger.kernel.org, "David S. Miller" , David Ahern , Stefano Brivio Subject: Re: [PATCH net v2 2/2] selftests: pmtu: add explicit tests for PMTU exceptions cleanup Message-ID: <20190225123330.GA10994@bistromath.localdomain> References: <6d6f6a2512743d6e1968dbfe765eb85b478bd033.1551093086.git.pabeni@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6d6f6a2512743d6e1968dbfe765eb85b478bd033.1551093086.git.pabeni@redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 25 Feb 2019 12:33:36 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 2019-02-25, 12:13:46 +0100, Paolo Abeni wrote: > + if ! timeout 1 ${ns_a} ip link del dev veth_A-R1; then That doesn't work. "ip link del" is stuck in a way that timeout can't terminate it, so this is still going to hang. Did you actually test this? :/ > + err " can't delete veth device in a timely manner, PMTU dst likely leaked" > + return 1 > + fi > + return 0 > +} -- Sabrina