From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF397C43381 for ; Mon, 25 Feb 2019 15:05:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6C602087C for ; Mon, 25 Feb 2019 15:05:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="u7cmCJd/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727552AbfBYPFB (ORCPT ); Mon, 25 Feb 2019 10:05:01 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:39879 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727473AbfBYPFB (ORCPT ); Mon, 25 Feb 2019 10:05:01 -0500 Received: by mail-pf1-f194.google.com with SMTP id i20so4629388pfo.6 for ; Mon, 25 Feb 2019 07:05:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jcIhfPQjbQ0HBgkQe5d/nvhtr5Y2x/pdcyv0wwLX1e0=; b=u7cmCJd/cTkFMd5ZU7B0kNeobRbmGod9PMWBfln2zA4FveuIoNbcGcoyjJcEuOmwuZ qubNAco5Rm8QkTPJnjTkYW6+5T0+IZzImHhvB5bLquFCEq+UA75Vj1iQO/GLSK6ySaeb ohw2DTBRTnCg3S9WSWpYYH5fbQUyMtSH6Bu1C4WJZm536mc7RtDNhJmFUOCptgKVPZn2 vuzIExOEIz5u01OfUE+v1z9TVVZxvJ1DXGp84qqc7DslYFdlvyJd48KHXldxMmegLXcR ASQs/WMq7zWWO6MuQQpDp2G20Ehmq4abG9YB7yIgpFgaQ06mM0vx2Te8fA57o8vyXfnb 3Swg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jcIhfPQjbQ0HBgkQe5d/nvhtr5Y2x/pdcyv0wwLX1e0=; b=IWat10vOJ+mYzzttJDovIQxn6smwxgF0Q1Cz1kD5GVB2/DHeK8iUxaEWa0q6bItpLa OxfJ8bLYDF7pOl6ik7z+tKNaNrutuuPcgFZ2QTH2HCqSV9PkXWg3IUMKJE7VKaB/lnL2 pcdXit36UZwDY4TKq0/p5BkTlw3T0lsl+WReNJ+rgaKPp7rFEYlVKt4Vn7BMSZDfyy+i QmD6fVtliAdVDWw75dPV4Hl9eAocYNfDjatyo99i7mPwJhxzqoFCxCyw8gMZ35+tTJ9V fg/1dmIDB9e+mFm+4BYHnEtE/BjPMsbUBYF4E+DTxEgjoH5hD1QXG+vEdA2BA6UV9QC5 XHyg== X-Gm-Message-State: AHQUAubULO/XCGYbtMZbP9FuLVWbcs0ejl+GEgAftXah4KOfqJI5z84M c4Az5EYcsik5MTY8cf6iRWI= X-Google-Smtp-Source: AHgI3IbnNnJossLQOqf+EbsVQ8NsAvJLc0RDiBPL4bHIGEWFvm+GQ5L6KjJGm4fAdope0lZWPEuK6A== X-Received: by 2002:aa7:8b09:: with SMTP id f9mr12230495pfd.168.1551107100286; Mon, 25 Feb 2019 07:05:00 -0800 (PST) Received: from Inspiron-3521 ([106.216.180.155]) by smtp.gmail.com with ESMTPSA id a20sm24355383pfj.5.2019.02.25.07.04.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Feb 2019 07:04:59 -0800 (PST) Date: Mon, 25 Feb 2019 20:34:53 +0530 From: Leslie Monis To: Dave Taht Cc: netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 0/7] net: sched: pie: align PIE implementation with RFC 8033 Message-ID: <20190225150453.GA16245@Inspiron-3521> References: <20190225102051.12268-1-lesliemonis@gmail.com> <19575745-ad10-be2d-6259-5fe39fa71264@mojatatu.com> <87ftsc2c1e.fsf@taht.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ftsc2c1e.fsf@taht.net> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 25, 2019 at 06:11:25AM -0800, Dave Taht wrote: > Jamal Hadi Salim writes: > > > On 2019-02-25 8:43 a.m., Jamal Hadi Salim wrote: > >> On 2019-02-25 5:20 a.m., Leslie Monis wrote: > >>> The current implementation of the PIE queuing discipline is > >>> according to the > >>> IETF draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and > >>> the paper > >>> [PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem]. > >>> However, a lot of necessary modifications and enhancements have > >>> been proposed > >>> in RFC 8033, which have not yet been incorporated in the source > >>> code of Linux. > >>> This patch series helps in achieving the same. > >>> > >>> Performance tests carried out using Flent [https://flent.org/] > >>> > >> > >> +Cc the authors of PIE to double check these values. > >> Please respond (it is how open source works!) and N/ACK > > > > Great. Bouncing addresses. > > D. Taht - can you look at this? > > Whose addresses are bouncing? The folk that did pie originally were > mostly contractors and long ago moved on to other things. > > My taht.net address tends to bounce to vger as I long ago mandated > starttls on all email transactions which is why I use my gmail account > for postings there. I keep hoping that one day vger will support > starttls... posting it here as I'm an optimist. I wasn't expecting to be > cc'd on this submittal.... > > Pie seems to be mostly an abandoned CISCO effort outside of docsis-pie, > at least at the moment. I've heard not a peep from them in years. > (fq_codel seems to have mostly "won" in our world) > > I did review all these changes when they went by in v1, and aside from > the ecn mistake ending up in the final RFC when I wasn't looking[1], > approve of these changes to sch_pie to make it compliant with the rfc, > finally. > > [1] We proposed refining pie's ecn handling here: > > https://github.com/gautamramk/FQ-PIE-for-Linux-Kernel/issues/2 > > Anyway: > > Acked-by: Dave Taht > Hi Dave, For now we would just like to make the PIE implementation meet the standards as expressed by the RFC. As ECN handling is outside the scope of the RFC we can consider refinements to it in the code later. Thanks, Leslie