From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69ED5C43381 for ; Tue, 26 Feb 2019 00:38:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3775C2184E for ; Tue, 26 Feb 2019 00:38:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="a5za/boQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729329AbfBZAiQ (ORCPT ); Mon, 25 Feb 2019 19:38:16 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:39647 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727200AbfBZAiP (ORCPT ); Mon, 25 Feb 2019 19:38:15 -0500 Received: by mail-pf1-f194.google.com with SMTP id i20so5309246pfo.6 for ; Mon, 25 Feb 2019 16:38:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vPBOLMfccRMORVvap3CbA9kAPOugPHGcynHLbo5JS5o=; b=a5za/boQqK+v+o1yPEQVR4BGUOAfS1mIB6icmVtkarbBy+oa7eZywetKz/cbtlPwZj pgxdsSB+iBwEP4XpqtsyznmTFNRxrktzsU5tcMODXNZeOpszSYUDaHk11x5iTUjUvwN1 teolBJiw4yuNQCfd5NQHIOd2UqqqqL5x52nH5Gyhy7b03EVVUdaVAquEzllYbH8EghRF WD1yKayhUwLeCHKb62Mc/Lh3JSQIQAakqECe2c5udKKee9ldnccxt1a2We4+ds7uHWge svzEOIVbR1aC/DW/Dh7ZcAcSMBU5qkiom/EjeE3jVXVu4bmN2SPzIBrRtFhXYbGm/SUj OBEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vPBOLMfccRMORVvap3CbA9kAPOugPHGcynHLbo5JS5o=; b=eHlh+B9WnMC8fBJU7ZBltRYzf6825k/OXU2DUC6Xvm6gobTW+E6tpSXNWMIdIcpDDR JskS7K7NOTJOif9PQOq3cMQqbihuW+N5lKtQ6sWd5WZGYq7DolPDP3Mduj113V8hxlAY fRdbyyzeK2JMbBX9ywbvH6/lTJ9tTZDUVUO/oYYv0d6MlLCq+csR8t7Zht6hFfj9S/Mm yMxUW+CNwya+f0rPOb8UjKIW89epm3La5viT/Ak6JVrHfeOKo2b8wN5toZzk2Zx6DKJZ GO6WJvt+qqiZSPjgsGI3ayrJkPkPAmUTWRnIvPoFrJq5D9Q3cxZ4/gPK5v2422SkYYmt 4IwQ== X-Gm-Message-State: AHQUAubS8upTUwGtbA/Wh57XI/WYFtbtjkW/Ku2qpn30UTrASa205de6 kg9YgoB81bnyXkfHFt1npuAJRg== X-Google-Smtp-Source: AHgI3IbzX2HILE+3osWPT+Acd9yb0b2YMIWa/hu57CekkO0aucP9YzzDpTbTPLWy4vSHihQPLo4qUQ== X-Received: by 2002:a62:4754:: with SMTP id u81mr23288370pfa.66.1551141494614; Mon, 25 Feb 2019 16:38:14 -0800 (PST) Received: from shemminger-XPS-13-9360 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 64sm16433099pff.101.2019.02.25.16.38.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Feb 2019 16:38:14 -0800 (PST) Date: Mon, 25 Feb 2019 16:38:11 -0800 From: Stephen Hemminger To: Leslie Monis Cc: davem@davemloft.net, netdev@vger.kernel.org, "Mohit P . Tahiliani" , Dave Taht , Jamal Hadi Salim Subject: Re: [PATCH net-next v3 0/7] net: sched: pie: align PIE implementation with RFC 8033 Message-ID: <20190225163811.4a6b477b@shemminger-XPS-13-9360> In-Reply-To: <20190225191001.26797-1-lesliemonis@gmail.com> References: <20190225191001.26797-1-lesliemonis@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 26 Feb 2019 00:39:54 +0530 Leslie Monis wrote: > The current implementation of the PIE queuing discipline is according to the > IETF draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and the paper > [PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem]. > However, a lot of necessary modifications and enhancements have been proposed > in RFC 8033, which have not yet been incorporated in the source code of Linux. > This patch series helps in achieving the same. > > Performance tests carried out using Flent [https://flent.org/] > > Changes from v2 to v3: > - Used div_u64() instead of direct division after explicit type casting as > recommended by David > > Changes from v1 to v2: > - Excluded the patch setting PIE dynamically active/inactive as the test > results were unsatisfactory > - Fixed a scaling issue when adding more auto-tuning cases which caused > local variables to underflow > - Changed the long if/else chain to a loop as suggested by Stephen > - Changed the position of the accu_prob variable in the pie_vars > structure as recommended by Stephen > > Mohit P. Tahiliani (7): > net: sched: pie: change value of QUEUE_THRESHOLD > net: sched: pie: change default value of pie_params->target > net: sched: pie: change default value of pie_params->tupdate > net: sched: pie: change initial value of pie_vars->burst_time > net: sched: pie: add more cases to auto-tune alpha and beta > net: sched: pie: add derandomization mechanism > net: sched: pie: update references > > include/uapi/linux/pkt_sched.h | 2 +- > net/sched/sch_pie.c | 107 ++++++++++++++++++++------------- > 2 files changed, 66 insertions(+), 43 deletions(-) Are you concerned at all that changes to default values might change expected behavior of existing users?