From: Pavel Machek <pavel@ucw.cz>
To: Joe Perches <joe@perches.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Tristram.Ha@microchip.com, andrew@lunn.ch,
sergio.paracuellos@gmail.com, UNGLinuxDriver@microchip.com,
netdev@vger.kernel.org
Subject: Re: [PATCH v1 net-next 2/4] net: dsa: microchip: add MIB counter reading support
Date: Mon, 25 Feb 2019 19:34:53 +0100 [thread overview]
Message-ID: <20190225183453.GA9243@amd> (raw)
In-Reply-To: <2cf3bf259bed9e44bd7e885850e45cb3a62e3779.camel@perches.com>
[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]
On Wed 2019-02-20 15:49:25, Joe Perches wrote:
> On Tue, 2019-02-12 at 19:51 -0800, Florian Fainelli wrote:
> > On February 12, 2019 6:39:49 PM PST, Tristram.Ha@microchip.com wrote:
> > > > > +static void ksz9477_freeze_mib(struct ksz_device *dev, int port,
> > > > > + bool freeze)
> > > > > +{
> > > > > + struct ksz_port *p = &dev->ports[port];
> > > > > + u32 val = freeze ? MIB_COUNTER_FLUSH_FREEZE : 0;
> > > >
> > > > Reverse Christmas tree.
> > >
> > > There was a checkpatch.pl patch in 2016 that tried to check this, but
> > > it was never accepted?
>
> https://lore.kernel.org/patchwork/patch/732076/
>
> While I still think use of reverse christmas tree is misguided,
> there were some disagreements about what form it really is:
Agreed about "misguided".
Often there's more logical order, like "self" pointer first... which
this patch follows.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-02-25 18:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 4:07 [PATCH v1 net-next 0/4] net: dsa: microchip: add MIB counters support Tristram.Ha
2019-02-08 4:07 ` [PATCH v1 net-next 1/4] net: dsa: microchip: prepare PHY for proper advertisement Tristram.Ha
2019-02-09 16:54 ` Andrew Lunn
2019-02-08 4:07 ` [PATCH v1 net-next 2/4] net: dsa: microchip: add MIB counter reading support Tristram.Ha
2019-02-09 17:22 ` Andrew Lunn
2019-02-13 2:39 ` Tristram.Ha
2019-02-13 3:28 ` Andrew Lunn
2019-02-13 3:51 ` Florian Fainelli
2019-02-14 19:26 ` Tristram.Ha
2019-02-14 19:33 ` Florian Fainelli
2019-02-20 23:49 ` Joe Perches
2019-02-25 18:34 ` Pavel Machek [this message]
2019-02-08 4:07 ` [PATCH v1 net-next 3/4] net: dsa: microchip: use readx_poll_time for polling Tristram.Ha
2019-02-09 17:01 ` Andrew Lunn
2019-02-13 2:53 ` Tristram.Ha
2019-02-08 4:07 ` [PATCH v1 net-next 4/4] net: dsa: microchip: remove unnecessary include headers Tristram.Ha
2019-02-09 17:01 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225183453.GA9243@amd \
--to=pavel@ucw.cz \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).