From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DD35C43381 for ; Mon, 25 Feb 2019 18:46:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29A162087C for ; Mon, 25 Feb 2019 18:46:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="gnR7vO/W" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728490AbfBYSqb (ORCPT ); Mon, 25 Feb 2019 13:46:31 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:33515 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728382AbfBYSqb (ORCPT ); Mon, 25 Feb 2019 13:46:31 -0500 Received: by mail-pl1-f193.google.com with SMTP id y10so4921837plp.0 for ; Mon, 25 Feb 2019 10:46:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9wHhpcla1wp8wiiDY89Bs462Cl5u0+m8Yz71J6hgkVI=; b=gnR7vO/Whny07ivKAyJ/Uja4SOD1Yil3Mi5MBWJ/FXJ3+P4Xi5TBp1wOJEd045NLlj YH6JJzbBLtxVqvo59ToBEdquwkj6ZvSzDnex1JCFTNi0857+dV5O341DJSaTGvIUnXBg PbRXStNp7XM/P/IPBTgyFpgKIIkhBHPBMlv1GMJVw1Wo7P0iTVtFnURPaE0MwgW/3PyD jMO1vEOl8SjWvLWTW7nhohbHNAn4qpicQBPB9MU8JZ3YN6flmwzvOWwr8iDNmHcBa4LN nEqUwSDcqQ9Q9280FxBXx5HPiQxXpv795Y6H6X5+v1P1Kn+y+dHDulyKQe3YZkf+8O4A 2Ulw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9wHhpcla1wp8wiiDY89Bs462Cl5u0+m8Yz71J6hgkVI=; b=BsFTfgk7Qbi6Z5LPW8OD7kKUctSALn9H1ZJ2xdRjHAq81uvH2BYfy9Fc9a2E3tOXlG K4VOOtpHqF/AD4nm3xXADQwtBQDk3quM41XzSRNAKq+06a1i4FDQ8eJPRoE3h13GSpLq 7CU9KO0cGREYw8Ry5qrwALziS2rbAIcjNOtimrZxX5J3hvJ8c3dg2EIHo5XiLQ9E6O53 80YYnc262iqXUp6GkZxJ8nSuYhkDm9GhBXl+bNcsXsFm7grLCgussGfvU+WmhFmE1gbd 5kXIFlc1Na1/DpLWYV/eigMdXMwFko2lwaT8eUAaTTVLxqdQJdYBuUkplnwrFzyVW7tD 392Q== X-Gm-Message-State: AHQUAuZj5Xo0+uuysFSzKL9AtJKm1Ix+KPoT8OURXD69+AD3bf1xNTz+ EkKCQRRC2WbHccKQB8gIzotadQ== X-Google-Smtp-Source: AHgI3IZYOM8vmZMYEGEdE83sNVyp8oV8TThHIzktF13wJWbIz/AmxVgOFwlv8Opi393YsA3ek8stLQ== X-Received: by 2002:a17:902:728d:: with SMTP id d13mr8257884pll.12.1551120390901; Mon, 25 Feb 2019 10:46:30 -0800 (PST) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id 1sm26378200pfy.68.2019.02.25.10.46.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Feb 2019 10:46:30 -0800 (PST) Received: from jgg by jggl.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1gyLGn-0005l5-MJ; Mon, 25 Feb 2019 11:46:29 -0700 Date: Mon, 25 Feb 2019 11:46:29 -0700 From: Jason Gunthorpe To: Gal Pressman Cc: Shiraz Saleem , dledford@redhat.com, davem@davemloft.net, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, mustafa.ismail@intel.com, jeffrey.t.kirsher@intel.com Subject: Re: [RFC v1 10/19] RDMA/irdma: Add connection manager Message-ID: <20190225184629.GC21863@ziepe.ca> References: <20190215171107.6464-1-shiraz.saleem@intel.com> <20190215171107.6464-11-shiraz.saleem@intel.com> <0eafe40b-4c54-dc12-6a85-3a821d99d2cd@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0eafe40b-4c54-dc12-6a85-3a821d99d2cd@amazon.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Feb 24, 2019 at 01:21:16PM +0200, Gal Pressman wrote: > On 15-Feb-19 19:10, Shiraz Saleem wrote: > > +/** > > + * irdma_cm_teardown_connections - teardown QPs > > + * @iwdev: device pointer > > + * @ipaddr: Pointer to IPv4 or IPv6 address > > + * @ipv4: flag indicating IPv4 when true > > There is no ipv4 parameter. Be sure to run code through make W=1 - it runs stuff that checks the kdocs. > > + INIT_LIST_HEAD(&teardown_list); > > + for (i = 0; i < IRDMA_MAX_USER_PRIORITY; i++) { > > + spin_lock_irqsave(&vsi->qos[i].lock, flags); > > + list_for_each_safe(list_node, list_core_temp, &vsi->qos[i].qplist) { > > + u32 qp_ip[4]; > > + > > + sc_qp = container_of(list_node, struct irdma_sc_qp, list); > > + if (sc_qp->qp_type != IRDMA_QP_TYPE_ROCE_RC) > > + continue; > > + > > + qp = sc_qp->back_qp; > > + if (!disconnect_all) { > > + if (nfo->ipv4) > > + qp_ip[0] = qp->udp_info.local_ipaddr3; > > + else > > + memcpy(qp_ip, > > + &qp->udp_info.local_ipaddr0, > > + sizeof(qp_ip)); > > + } > > + > > + if (disconnect_all || > > + (nfo->vlan_id == qp->udp_info.vlan_tag && > > + !memcmp(qp_ip, ipaddr, nfo->ipv4 ? 4 : 16))) { > > + spin_lock_irqsave(&iwdev->rf->qptable_lock, flags); > > You should use different 'flags' here. If irqs are already proven disabled it is just spin_lock, right? Jason