From: Petr Vorel <pvorel@suse.cz>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 1/1] man: Document COLORFGBG environment variable
Date: Mon, 25 Feb 2019 22:38:28 +0100 [thread overview]
Message-ID: <20190225213828.GA2931@x230> (raw)
In-Reply-To: <20190221100931.0bfcf868@shemminger-XPS-13-9360>
Hi Stephen,
> > Default colors are not contrast enough on dark backround
> > and this functionality, which uses more suitable colors
> > is hidden in the code.
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> COLORFGBG is a semi-standard thing used by many programs.
> Maybe a reference to a more complete description of it on the web
> might be better.
If there is any, I'd have added the link instead :).
So I used the description from the code I got inspiration when adding COLORFGBG
support into iproute2. This description is actually complete for our usage of
the variable. If you don't like it, even mentioning COLORFGBG in man would be
better than nothing (one would look into the source).
People have asked for it before [1].
Kind regards,
Petr
[1] https://patchwork.ozlabs.org/patch/814394/
prev parent reply other threads:[~2019-02-25 21:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 15:04 [PATCH iproute2 1/1] man: Document COLORFGBG environment variable Petr Vorel
2019-02-21 18:09 ` Stephen Hemminger
2019-02-25 21:38 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225213828.GA2931@x230 \
--to=pvorel@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).