From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FF1AC10F00 for ; Mon, 25 Feb 2019 21:38:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4603B20578 for ; Mon, 25 Feb 2019 21:38:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732839AbfBYVie (ORCPT ); Mon, 25 Feb 2019 16:38:34 -0500 Received: from mx2.suse.de ([195.135.220.15]:33554 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732161AbfBYVic (ORCPT ); Mon, 25 Feb 2019 16:38:32 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9FA30B174; Mon, 25 Feb 2019 21:38:30 +0000 (UTC) Date: Mon, 25 Feb 2019 22:38:28 +0100 From: Petr Vorel To: Stephen Hemminger Cc: netdev@vger.kernel.org Subject: Re: [PATCH iproute2 1/1] man: Document COLORFGBG environment variable Message-ID: <20190225213828.GA2931@x230> Reply-To: Petr Vorel References: <20190221150401.618-1-pvorel@suse.cz> <20190221100931.0bfcf868@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190221100931.0bfcf868@shemminger-XPS-13-9360> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Stephen, > > Default colors are not contrast enough on dark backround > > and this functionality, which uses more suitable colors > > is hidden in the code. > > Signed-off-by: Petr Vorel > COLORFGBG is a semi-standard thing used by many programs. > Maybe a reference to a more complete description of it on the web > might be better. If there is any, I'd have added the link instead :). So I used the description from the code I got inspiration when adding COLORFGBG support into iproute2. This description is actually complete for our usage of the variable. If you don't like it, even mentioning COLORFGBG in man would be better than nothing (one would look into the source). People have asked for it before [1]. Kind regards, Petr [1] https://patchwork.ozlabs.org/patch/814394/