From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5774C43381 for ; Tue, 26 Feb 2019 16:50:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FD232147C for ; Tue, 26 Feb 2019 16:50:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728703AbfBZQuL (ORCPT ); Tue, 26 Feb 2019 11:50:11 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:56988 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726801AbfBZQuK (ORCPT ); Tue, 26 Feb 2019 11:50:10 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 068AB14F1D9F2; Tue, 26 Feb 2019 08:50:09 -0800 (PST) Date: Tue, 26 Feb 2019 08:50:09 -0800 (PST) Message-Id: <20190226.085009.1852402564933343298.davem@davemloft.net> To: jakub.kicinski@netronome.com Cc: jiri@resnulli.us, mkubecek@suse.cz, andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next v4 0/6] devlink: make ethtool compat reliable From: David Miller In-Reply-To: <20190226033407.32625-1-jakub.kicinski@netronome.com> References: <20190226033407.32625-1-jakub.kicinski@netronome.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 26 Feb 2019 08:50:10 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jakub Kicinski Date: Mon, 25 Feb 2019 19:34:01 -0800 > This is a follow up to the series which added device flash > updates via devlink. I went with the approach of adding a > new NDO in the end. It seems to end up looking cleaner. > > First patch removes the option to build devlink as a module. > Users can still decide to not build it, but the module option > ends up not being worth the maintenance cost. > > Next two patches add a NDO which can be used to ask the driver > to return a devlink instance associated with a given netdev, > instead of iterating over devlink ports. Drivers which implement > this NDO must take into account the potential impact on the > visibility of the devlink instance. > > With the new NDO in place we can remove NFP ethtool flash update > code. > > Fifth patch makes sure we hold a reference to dev while > callbacks are active. > > Last but not least the NULL-check of devlink->ops is moved > to instance allocation time. > > Last but not least missing checks for devlink->ops are added. > There is currently no driver registering devlink without ops, > so can just fix this in -next. > > v2 (Michal): add netdev_to_devlink() in patch 3. > v3 (Florian): > - add missing checks for devlink->ops; > - move locking/holding into devlink_compat_ functions. > v4 (Jiri): > - hold devlink_mutex around callbacks (patch 2); > - require non-NULL ops (patch 6). Series applied, thanks Jakub.