From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED6FCC43381 for ; Tue, 26 Feb 2019 17:20:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF00021848 for ; Tue, 26 Feb 2019 17:20:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727704AbfBZRUX (ORCPT ); Tue, 26 Feb 2019 12:20:23 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:57328 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726801AbfBZRUX (ORCPT ); Tue, 26 Feb 2019 12:20:23 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D776214F1DCE0; Tue, 26 Feb 2019 09:20:22 -0800 (PST) Date: Tue, 26 Feb 2019 09:20:22 -0800 (PST) Message-Id: <20190226.092022.2234839678147533062.davem@davemloft.net> To: vladbu@mellanox.com Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us Subject: Re: [PATCH net-next] net: sched: fix typo in walker_check_empty() From: David Miller In-Reply-To: <20190226153440.17349-1-vladbu@mellanox.com> References: <20190226153440.17349-1-vladbu@mellanox.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 26 Feb 2019 09:20:23 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vlad Buslov Date: Tue, 26 Feb 2019 17:34:40 +0200 > Function walker_check_empty() incorrectly verifies that tp pointer is not > NULL, instead of actual filter pointer. Fix conditional to check the right > pointer. Adjust filter pointer naming accordingly to other cls API > functions. > > Fixes: 6676d5e416ee ("net: sched: set dedicated tcf_walker flag when tp is empty") > Signed-off-by: Vlad Buslov > Reported-by: Cong Wang Applied.