From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=f3Oa=RB=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D494DC43381
	for <netdev@archiver.kernel.org>; Tue, 26 Feb 2019 21:17:00 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 9505F21850
	for <netdev@archiver.kernel.org>; Tue, 26 Feb 2019 21:17:00 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728854AbfBZVQ7 (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Tue, 26 Feb 2019 16:16:59 -0500
Received: from shards.monkeyblade.net ([23.128.96.9]:60004 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727823AbfBZVQ7 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 26 Feb 2019 16:16:59 -0500
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id E959214F2506B;
        Tue, 26 Feb 2019 13:16:58 -0800 (PST)
Date:   Tue, 26 Feb 2019 13:16:58 -0800 (PST)
Message-Id: <20190226.131658.663280846317438258.davem@davemloft.net>
To:     michael.chan@broadcom.com
Cc:     maheshb@google.com, edumazet@google.com, netdev@vger.kernel.org,
        dja@axtens.net
Subject: Re: [PATCH RFC] net: Validate size of non-TSO packets in
 validate_xmit_skb().
From:   David Miller <davem@davemloft.net>
In-Reply-To: <CACKFLim51U_NGEU9nH5ZPWiup==aDLQM+x3p_O0-3EerZQ74hg@mail.gmail.com>
References: <1551178601-16564-1-git-send-email-michael.chan@broadcom.com>
        <20190226.091324.1656342529138987636.davem@davemloft.net>
        <CACKFLim51U_NGEU9nH5ZPWiup==aDLQM+x3p_O0-3EerZQ74hg@mail.gmail.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 26 Feb 2019 13:16:59 -0800 (PST)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Michael Chan <michael.chan@broadcom.com>
Date: Tue, 26 Feb 2019 10:22:42 -0800

> On Tue, Feb 26, 2019 at 9:13 AM David Miller <davem@davemloft.net> wrote:
>>
>> From: Michael Chan <michael.chan@broadcom.com>
>> Date: Tue, 26 Feb 2019 05:56:41 -0500
>>
>> > There have been reports of oversize UDP packets being sent to the
>> > driver to be transmitted, causing error conditions.  The issue is
>> > likely caused by the dst of the SKB switching between 'lo' with
>> > 64K MTU and the hardware device with a smaller MTU.  Patches are
>> > being proposed by Mahesh Bandewar <maheshb@google.com> to fix the
>> > issue.
>> >
>> > Separately, we should add a length check in validate_xmit_skb()
>> > to drop these oversize packets before they reach the driver.
>> > This patch only validates non-TSO packets.  Complete validation
>> > of segmented TSO packet size will probably be too slow.
>> >
>> > Signed-off-by: Michael Chan <michael.chan@broadcom.com>
>>
>> Anything which changes the dst of an SKB really is responsible for
>> fixing up whatever became "incompatible" in the new path.
>>
>> So like Eric I want to see this out of the fast path.
> 
> Ok.  In the meantime, will you take a 2-line bnxt_en patch that will
> prevent this issue in kernel 5.0?

Sure, but we will have to remember to remove it when it is no longer
necessary...