From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DC0CC43381 for ; Tue, 26 Feb 2019 09:06:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECB45213A2 for ; Tue, 26 Feb 2019 09:06:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="oKx4jqFI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727560AbfBZJGW (ORCPT ); Tue, 26 Feb 2019 04:06:22 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:41114 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727051AbfBZJGW (ORCPT ); Tue, 26 Feb 2019 04:06:22 -0500 Received: by mail-wr1-f68.google.com with SMTP id n2so12994522wrw.8 for ; Tue, 26 Feb 2019 01:06:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/Za8ZtO++w+76TGH2x5qzQHdSn3dA84z0UDhY80U28k=; b=oKx4jqFIcyb/gcDkHmgHCflzQr3Jk+cHtW39kjJzvh31k8NWk5DhLIWFk/J9Q7mVI4 LgjuyGiE8W0B83JzrMMhvX6uxgenFAqbJp93VoVADQ4Qh7se5qUChUwNMvgeba5jjKKc YhF3scda6o73DdmZLfW/+oPoB0PgfYUQMJL5sXkQzK65WVOLW+VKRCivW0+yCelYv5Hg emKVkisLxjw7YkTSxwHSIj+97z2J//TntNP2SLaU7+BthZ/OBUVheJpfck9f0D7SHJeU v7AfDX7XdIHnAqyJn76qy+Cihdh6XeiEQM4XNMHevHu+vvf28pmc/hvi4/0yHtN/l5vo BdAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/Za8ZtO++w+76TGH2x5qzQHdSn3dA84z0UDhY80U28k=; b=PcWvit+xHsZ7S6hrieatS2s9RcXTW2qX8QogxNbCyJOJw1DmUEGevk5P2FReEHpdS9 F86xb39Eqjqqx8KElihHR0XX6TvZvESkP+4G3FP0SY8Kn+qqYde+m8YbuPexKzjVBc3T U/wAXD6GeNXQGqM+DwxMtk+9Yuqm6KiOlvh56kiDC5eWmuCUAV4sqm31YEUPAbpQ0AlU 21TuTgxvd1spBaM7W7eFL1Q1Kvf5cswZ4LupqO95SShdnPQ3hU2KhzLBckYzPvy8qp45 zB70ZzFGy1B8QJKgzePD8ok/0TZfrPBm6VntF6+zwnF4GSuy9G2+Ca+5svtvpqhH2M1D DNRw== X-Gm-Message-State: AHQUAuY+8R9oVI+jj1JlJF4QtvHu2uP3VJGGR2qeTIdGGsNUvM6mOiqh mqwclYj1wQA29oNNv0jBcvpHyQ== X-Google-Smtp-Source: AHgI3IaE0lxhhF/bAwtIfaYYWOVgIzE0aFiHtKZ1DrLKgCocRxpPbNvs7Ej9aBGRU7IA9yEqfthnSA== X-Received: by 2002:a5d:4149:: with SMTP id c9mr16158413wrq.58.1551171980796; Tue, 26 Feb 2019 01:06:20 -0800 (PST) Received: from localhost ([2001:718:603:100a:93d:1bfc:765a:ba68]) by smtp.gmail.com with ESMTPSA id t9sm11083463wrx.73.2019.02.26.01.06.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Feb 2019 01:06:20 -0800 (PST) Date: Tue, 26 Feb 2019 09:56:29 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, mkubecek@suse.cz, andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next v4 2/6] devlink: create a special NDO for getting the devlink instance Message-ID: <20190226085629.GB5451@nanopsycho> References: <20190226033407.32625-1-jakub.kicinski@netronome.com> <20190226033407.32625-3-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190226033407.32625-3-jakub.kicinski@netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, Feb 26, 2019 at 04:34:03AM CET, jakub.kicinski@netronome.com wrote: >Instead of iterating over all devlink ports add a NDO which >will return the devlink instance from the driver. > >v2: add the netdev_to_devlink() helper (Michal) >v3: check that devlink has ops (Florian) >v4: hold devlink_mutex (Jiri) > >Suggested-by: Jiri Pirko >Signed-off-by: Jakub Kicinski >Reviewed-by: Florian Fainelli Acked-by: Jiri Pirko