From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEFE3C43381 for ; Tue, 26 Feb 2019 09:07:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FF14213A2 for ; Tue, 26 Feb 2019 09:07:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="QqPTgBgK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727357AbfBZJHX (ORCPT ); Tue, 26 Feb 2019 04:07:23 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:38625 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727051AbfBZJHX (ORCPT ); Tue, 26 Feb 2019 04:07:23 -0500 Received: by mail-wr1-f67.google.com with SMTP id g12so934982wrm.5 for ; Tue, 26 Feb 2019 01:07:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=s7AsWNXnb0Gn5kjhOe+O97P+ncJmDLYTcnqt8EFU5jE=; b=QqPTgBgKalAzg15Z2pJv6vqC/ABl+1Ge84Z92hJbfIP5YTZ7lnke43V9TTj/5FtNBc WV3EltGPVWoNmSO6Ad0DBRhri/P1aq1RdqNj4KqNWimjENq/58pffe/KAdKngMAfMFra hdlyST9yJL59Kdtf9SAxAVtKk0BLP0H2fIcCgsX00h0Rzcbsx3u6aHi5WVhpsxglCWR4 xGRpjC2XX4kcJiWJWmNLJFNlfQ0J6Z5zi1HlRLMNtJew4yILYgzPZpoHOGatPj+HjkCy /T0NFeSMjIdKpB6OKeU3+3Fsk/BnCTQwNp9cd1yBWdp4YJwIgNtAHoI3BUoSoyZ2z2gb MtHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=s7AsWNXnb0Gn5kjhOe+O97P+ncJmDLYTcnqt8EFU5jE=; b=kWF8hoUgefBVczLrI3ugEmq+cC/lJ8Y4NKPV34AxddF54sHFHWVu9mxMOnlore3kCT EZPWr43dV73hNaCKdICWBU4mbxY7VouD8dmlsh4uiCqkDzMCd4djI0fqRxScFXss1Xqr DLbraE0gOxwaxHerP5KxGBGUjr4JlKxbHoVM/EfZWhGfcH8zIJUZTt6vt0LmRX5Jlye7 JKf1jMIOqTK+WJTAo9xScHJZfJuKQfzR4x7Vlts/SM1B72dh8xmjKP7pmk8SPoITwkWG l7CAeEqXuAz8zCoN72SivzWVPWuxzEu5RtQY0xNqESzULk/UvF6YbnE6vaJp0yakMNVP Bs0g== X-Gm-Message-State: AHQUAubNY6BkUtYj6SvQggNe624UmZ+ZAq+6XPtVqwLBhvtGYNRI2DFz xsjbutCvUblkD81nqD53aSLTbQ== X-Google-Smtp-Source: AHgI3IYg4sbctGIaMvFYyk41tzl5fJvioHNhVkmO4clfYvwXNqOR10Xo3GQvW29PpGr5VOxjwpnpuQ== X-Received: by 2002:adf:b687:: with SMTP id j7mr16426207wre.81.1551172041197; Tue, 26 Feb 2019 01:07:21 -0800 (PST) Received: from localhost ([2001:718:603:100a:93d:1bfc:765a:ba68]) by smtp.gmail.com with ESMTPSA id p16sm26522825wro.25.2019.02.26.01.07.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Feb 2019 01:07:20 -0800 (PST) Date: Tue, 26 Feb 2019 09:57:30 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, mkubecek@suse.cz, andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next v4 5/6] devlink: hold a reference to the netdevice around ethtool compat Message-ID: <20190226085730.GC5451@nanopsycho> References: <20190226033407.32625-1-jakub.kicinski@netronome.com> <20190226033407.32625-6-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190226033407.32625-6-jakub.kicinski@netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, Feb 26, 2019 at 04:34:06AM CET, jakub.kicinski@netronome.com wrote: >When ethtool is calling into devlink compat code make sure we have >a reference on the netdevice on which the operation was invoked. > >v3: move the hold/lock logic into devlink_compat_* functions (Florian) > >Signed-off-by: Jakub Kicinski Acked-by: Jiri Pirko