From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96954C10F0B for ; Tue, 26 Feb 2019 17:00:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5837B2173C for ; Tue, 26 Feb 2019 17:00:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551200408; bh=0J894FBtwR+rbjglb3tqjUbm7jRJoQADDqyjxiTLgyc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xKWdiQ1l55hUf8foaEkcDVBR7dk+AcvstUJcGhNJ8nDDoD4cko1hhPXH+GEdDxckQ jLZzTAs0wBilII9dxhEHY899OJJ4r9xZKF4r5WzDdX/aK2eP4cJv2/RGEX9S4kpAx0 NxhImx7hukUK0VlnaYtn16X02iw7Oyex8B7hQuts= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728249AbfBZRAH (ORCPT ); Tue, 26 Feb 2019 12:00:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:40776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727704AbfBZRAG (ORCPT ); Tue, 26 Feb 2019 12:00:06 -0500 Received: from kenny.it.cumulusnetworks.com. (fw.cumulusnetworks.com [216.129.126.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 351D021850; Tue, 26 Feb 2019 17:00:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551200406; bh=0J894FBtwR+rbjglb3tqjUbm7jRJoQADDqyjxiTLgyc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bjXetKxWOh2LmPHq2Kbgn8UPwfmi/SbwbXnWHve1o2mn9kD1/5xwqz4GlDMb11VMZ F0eC+ujLG0MBBspwMyN3e66slrFYmGjL1NVx5SZMEW8y+NPF04aiLu/M4upg21R1d0 y135cKpW2siVm4tx6C3nS7vRAJABIAPFbrcIvhqw= From: David Ahern To: davem@davemloft.net Cc: netdev@vger.kernel.org, David Ahern Subject: [PATCH net 2/3] ipv6: Return error for RTA_VIA attribute Date: Tue, 26 Feb 2019 09:00:03 -0800 Message-Id: <20190226170004.4535-3-dsahern@kernel.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190226170004.4535-1-dsahern@kernel.org> References: <20190226170004.4535-1-dsahern@kernel.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: David Ahern IPv6 currently does not support nexthops outside of the AF_INET6 family. Specifically, it does not handle RTA_VIA attribute. If it is passed in a route add request, the actual route added only uses the device which is clearly not what the user intended: $ ip -6 ro add 2001:db8:2::/64 via inet 172.16.1.1 dev eth0 $ ip ro ls ... 2001:db8:2::/64 dev eth0 metric 1024 pref medium Catch this and fail the route add: $ ip -6 ro add 2001:db8:2::/64 via inet 172.16.1.1 dev eth0 Error: IPv6 does not support RTA_VIA attribute. Fixes: 03c0566542f4c ("mpls: Netlink commands to add, remove, and dump routes") Signed-off-by: David Ahern --- net/ipv6/route.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index ce15dc4ccbfa..b7a620023a52 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -4182,6 +4182,10 @@ static int rtm_to_fib6_config(struct sk_buff *skb, struct nlmsghdr *nlh, cfg->fc_gateway = nla_get_in6_addr(tb[RTA_GATEWAY]); cfg->fc_flags |= RTF_GATEWAY; } + if (tb[RTA_VIA]) { + NL_SET_ERR_MSG(extack, "IPv6 does not support RTA_VIA attribute"); + goto errout; + } if (tb[RTA_DST]) { int plen = (rtm->rtm_dst_len + 7) >> 3; -- 2.11.0