From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B6D1C43381 for ; Tue, 26 Feb 2019 17:49:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3ECA21850 for ; Tue, 26 Feb 2019 17:49:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="O70KlK7h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728831AbfBZRt0 (ORCPT ); Tue, 26 Feb 2019 12:49:26 -0500 Received: from mail-qt1-f201.google.com ([209.85.160.201]:51849 "EHLO mail-qt1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727624AbfBZRtZ (ORCPT ); Tue, 26 Feb 2019 12:49:25 -0500 Received: by mail-qt1-f201.google.com with SMTP id s8so12744503qth.18 for ; Tue, 26 Feb 2019 09:49:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=d5iyDVl6f3/9CKQ99srjZ8+6ac56ZtIDiJW1G7u5SxY=; b=O70KlK7htex1irsKcxJbCqbyqdG1kzkRYgu5Ks/CXWKVbX0ikLIftBUsPnrn+Ibj/K nppnX1DWvz7/Zscp0apnEZBkcpzAuaCUi0oNsiTFy5mQZ4X8okQGTRLz+plzAQuFX7TK 1gT/cn6jLTHobluoc13P9nfHFllyKRkCjh6bXWr+41ugADNrrkbuNRnSXVZCdMoZKyq1 U/8qjvrURbcqGgzvCGDOVmf19Gg0kLwVXTCGrMB+Su3MQKitQWGpy+y3W1rD1zfoBBmD jljYc9/3Sn3AzkTwQpsT2BD/X93Xwy1FzPVC+7hrJU+2pM2CfqsBWF60L7ykBgQwFsIC vs6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=d5iyDVl6f3/9CKQ99srjZ8+6ac56ZtIDiJW1G7u5SxY=; b=XtKw1nQ2cBFM5Y4yax7zzI63LXMCYpZlCfkVREtNGh/nvZJ+OpXEw3WQoFQ2CyrCkR ADz45bCiR7JuGlD9dr7u3LB0Y++g0RJ0/IA7fGAMRn/HmHXpc2B0Vv07d6ndeVjs2Rga xwSKHNxqXMuMXdMBda/079CgqjweNooIyNIYaM4/turP+Tm97rk3BSrzXBKRaJ9+wXcz lM1tcrRpHonejsot7bqzGpK6gDaBShky8hmolQ5GoIh8wX7r4tVaarEwHa2RsAq+c2AK d/BRpt93DQkDp4OvPwVCeC64LqEaF0JqaZlbDLacUqtbDWYUtw1LWhg225GnOg0BglsW 9Kvg== X-Gm-Message-State: AHQUAuZU/+GnZXAgu2xzOKP4TBxCjXfi6+U2m4yNbYrXaGYONa3XjJhN NYO0SfDblWKFXl9OShMgTvvZlYXwRsjDpA== X-Google-Smtp-Source: AHgI3IY38cjLURYZAHHTJzlKMcUh2v3Qu741F2zus5m/PcfsXc2QdZKrvyS7Zkkia+P/Bs48Pia0zG/sO13XJg== X-Received: by 2002:ac8:24f9:: with SMTP id t54mr13974351qtt.46.1551203364982; Tue, 26 Feb 2019 09:49:24 -0800 (PST) Date: Tue, 26 Feb 2019 09:49:10 -0800 In-Reply-To: <20190226174913.18824-1-edumazet@google.com> Message-Id: <20190226174913.18824-3-edumazet@google.com> Mime-Version: 1.0 References: <20190226174913.18824-1-edumazet@google.com> X-Mailer: git-send-email 2.21.0.rc2.261.ga7da99ff1b-goog Subject: [PATCH net-next 2/5] tcp: get rid of __tcp_add_write_queue_tail() From: Eric Dumazet To: "David S . Miller" Cc: netdev , Eric Dumazet , Eric Dumazet Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This helper is only used from tcp_add_write_queue_tail(), and does not make the code more readable. Signed-off-by: Eric Dumazet --- include/net/tcp.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index 813042c08dc5a7438279821890439b02490391d1..d66ac76a33d1298e48bb9dcef217beaedc8a7968 100644 --- a/include/net/tcp.h +++ b/include/net/tcp.h @@ -1716,14 +1716,9 @@ static inline bool tcp_rtx_and_write_queues_empty(const struct sock *sk) return tcp_rtx_queue_empty(sk) && tcp_write_queue_empty(sk); } -static inline void __tcp_add_write_queue_tail(struct sock *sk, struct sk_buff *skb) -{ - __skb_queue_tail(&sk->sk_write_queue, skb); -} - static inline void tcp_add_write_queue_tail(struct sock *sk, struct sk_buff *skb) { - __tcp_add_write_queue_tail(sk, skb); + __skb_queue_tail(&sk->sk_write_queue, skb); /* Queue it, remembering where we must start sending. */ if (sk->sk_write_queue.next == skb) -- 2.21.0.rc2.261.ga7da99ff1b-goog