From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBEA1C43381 for ; Tue, 26 Feb 2019 18:24:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AAA99217F5 for ; Tue, 26 Feb 2019 18:24:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="ggkGNLrU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729055AbfBZSYw (ORCPT ); Tue, 26 Feb 2019 13:24:52 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:45039 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728920AbfBZSYv (ORCPT ); Tue, 26 Feb 2019 13:24:51 -0500 Received: by mail-qt1-f193.google.com with SMTP id d2so15995613qti.11 for ; Tue, 26 Feb 2019 10:24:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LwyaoMTc0583VDcl6/eRBBSG+wKQpUsn8AvrJrTaxgc=; b=ggkGNLrUhec/4FeeiOmDe48/VZ5Usc2VZPV5jKPxChuOtCWWPYF5YEW6goPHPFMVth ULxpdDzzXoSNl15YuKog8a7ostqOTgtQYb3x9YIUsHd/gsr7iRrcxiDoWe9uMIphn1lD xlcNb01eHRO8767/4dHpWevRbS+D0N1IKMXQwYsjzYbER+uZY4iKSzyQ44MnRbiGz0J6 AMCpZnN/cANfsZwcAN9IcGFqb1kCUtTWrsOqqxl6RR+Gpq3AFBSFdxeJ5GNMndXaM/1b HsW2tQmWq4SI/HEh99hOBNhfiVJNqGhGRte8tGb4zD+cKzyUpkPl1Zu7s8MNxpZlgmvS eWig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LwyaoMTc0583VDcl6/eRBBSG+wKQpUsn8AvrJrTaxgc=; b=Q6ONkrvueaNeIu9G6xgmDhcz36IwWCCW6Doe4sVjn0n3aoqlvqd4L90F6yce9qpgRy UCBD9ITmLwJ3TPt7EJX4F9k8lyYEyhbkAQEpfSJFsKpgYgyXJin9FaSQ1gEvhwcvFXgu DthWO6/o7F7U7pGY2s44Ocxa+d2+cKT+Jq/Ys6jNNZR+dlAckRNdPIf6A0lcG7e6ms/F qDFzV3zhZ5Xae4pyhFKWI0zB2411HOo61WOFrTODomixahKmDxMQwMQ8DlNW1A1Eho7v Uox4+y6fyNPMFfSxt07SWt1fPvaWsVZKyYxh0gaAdqKTiXzueb9mVMIn4aB8y6Fpz8cq /Fhw== X-Gm-Message-State: AHQUAubuLC/4lGaRb6177AekYUrhUL9tWTpAagcWYs1OtjJ4StpKYc0Q UB0snmT9hASqa8Pq+5OHq3PyCslmmFU= X-Google-Smtp-Source: AHgI3IZZFDJ9wZHT44YP0xw0u9PMvl77+o6FP5gg1vsFf+LxRpvr6OruC5Sin7EXIDJZlyJiy9hWNQ== X-Received: by 2002:ac8:2fd1:: with SMTP id m17mr19578548qta.301.1551205489639; Tue, 26 Feb 2019 10:24:49 -0800 (PST) Received: from jkicinski-Precision-T1700.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id u31sm9733892qth.15.2019.02.26.10.24.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Feb 2019 10:24:49 -0800 (PST) From: Jakub Kicinski To: davem@davemloft.net, jiri@resnulli.us Cc: oss-drivers@netronome.com, netdev@vger.kernel.org, Jakub Kicinski Subject: [PATCH net-next 1/8] nfp: split devlink port init from registration Date: Tue, 26 Feb 2019 10:24:29 -0800 Message-Id: <20190226182436.23811-2-jakub.kicinski@netronome.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190226182436.23811-1-jakub.kicinski@netronome.com> References: <20190226182436.23811-1-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In the future we want to switch to using the devlink_port_get_phys_port_name() helper for .ndo_phys_port_name. This requires that we initialize the devlink ports before the netdevs are registered. Split the registration from init. Signed-off-by: Jakub Kicinski --- .../net/ethernet/netronome/nfp/nfp_devlink.c | 13 ++++++++++--- .../net/ethernet/netronome/nfp/nfp_net_main.c | 17 ++++++++++++++--- drivers/net/ethernet/netronome/nfp/nfp_port.h | 2 ++ 3 files changed, 26 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c index e9eca99cf493..9af3cb1f2f17 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_devlink.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_devlink.c @@ -350,10 +350,9 @@ const struct devlink_ops nfp_devlink_ops = { .flash_update = nfp_devlink_flash_update, }; -int nfp_devlink_port_register(struct nfp_app *app, struct nfp_port *port) +int nfp_devlink_port_init(struct nfp_app *app, struct nfp_port *port) { struct nfp_eth_table_port eth_port; - struct devlink *devlink; int ret; rtnl_lock(); @@ -366,8 +365,16 @@ int nfp_devlink_port_register(struct nfp_app *app, struct nfp_port *port) devlink_port_attrs_set(&port->dl_port, DEVLINK_PORT_FLAVOUR_PHYSICAL, eth_port.label_port, eth_port.is_split, eth_port.label_subport); + return 0; +} + +void nfp_devlink_port_clean(struct nfp_port *port) +{ +} - devlink = priv_to_devlink(app->pf); +int nfp_devlink_port_register(struct nfp_app *app, struct nfp_port *port) +{ + struct devlink *devlink = priv_to_devlink(app->pf); return devlink_port_register(devlink, &port->dl_port, port->eth_id); } diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c b/drivers/net/ethernet/netronome/nfp/nfp_net_main.c index 08f5fdbd8e41..39e87bb73ebf 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_main.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_main.c @@ -150,9 +150,15 @@ nfp_net_pf_init_vnic(struct nfp_pf *pf, struct nfp_net *nn, unsigned int id) nn->id = id; + if (nn->port) { + err = nfp_devlink_port_init(pf->app, nn->port); + if (err) + return err; + } + err = nfp_net_init(nn); if (err) - return err; + goto err_port_clean; nfp_net_debugfs_vnic_add(nn, pf->ddir); @@ -167,17 +173,20 @@ nfp_net_pf_init_vnic(struct nfp_pf *pf, struct nfp_net *nn, unsigned int id) if (nfp_net_is_data_vnic(nn)) { err = nfp_app_vnic_init(pf->app, nn); if (err) - goto err_devlink_port_clean; + goto err_port_unreg; } return 0; -err_devlink_port_clean: +err_port_unreg: if (nn->port) nfp_devlink_port_unregister(nn->port); err_dfs_clean: nfp_net_debugfs_dir_clean(&nn->debugfs_dir); nfp_net_clean(nn); +err_port_clean: + if (nn->port) + nfp_devlink_port_clean(nn->port); return err; } @@ -224,6 +233,8 @@ static void nfp_net_pf_clean_vnic(struct nfp_pf *pf, struct nfp_net *nn) nfp_devlink_port_unregister(nn->port); nfp_net_debugfs_dir_clean(&nn->debugfs_dir); nfp_net_clean(nn); + if (nn->port) + nfp_devlink_port_clean(nn->port); } static int nfp_net_pf_alloc_irqs(struct nfp_pf *pf) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_port.h b/drivers/net/ethernet/netronome/nfp/nfp_port.h index 90ae053f5c07..09c55ca2371a 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_port.h +++ b/drivers/net/ethernet/netronome/nfp/nfp_port.h @@ -129,6 +129,8 @@ int nfp_net_refresh_eth_port(struct nfp_port *port); void nfp_net_refresh_port_table(struct nfp_port *port); int nfp_net_refresh_port_table_sync(struct nfp_pf *pf); +int nfp_devlink_port_init(struct nfp_app *app, struct nfp_port *port); +void nfp_devlink_port_clean(struct nfp_port *port); int nfp_devlink_port_register(struct nfp_app *app, struct nfp_port *port); void nfp_devlink_port_unregister(struct nfp_port *port); -- 2.19.2