From: David Miller <davem@davemloft.net>
To: michael.chan@broadcom.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] bnxt_en: Drop oversize TX packets to prevent errors.
Date: Wed, 27 Feb 2019 09:30:21 -0800 (PST) [thread overview]
Message-ID: <20190227.093021.1467529615785669970.davem@davemloft.net> (raw)
In-Reply-To: <1551257933-13270-1-git-send-email-michael.chan@broadcom.com>
From: Michael Chan <michael.chan@broadcom.com>
Date: Wed, 27 Feb 2019 03:58:53 -0500
> There have been reports of oversize UDP packets being sent to the
> driver to be transmitted, causing error conditions. The issue is
> likely caused by the dst of the SKB switching between 'lo' with
> 64K MTU and the hardware device with a smaller MTU. Patches are
> being proposed by Mahesh Bandewar <maheshb@google.com> to fix the
> issue.
>
> In the meantime, add a quick length check in the driver to prevent
> the error. The driver uses the TX packet size as index to look up an
> array to setup the TX BD. The array is large enough to support all MTU
> sizes supported by the driver. The oversize TX packet causes the
> driver to index beyond the array and put garbage values into the
> TX BD. Add a simple check to prevent this.
>
> Signed-off-by: Michael Chan <michael.chan@broadcom.com>
> ---
>
> David, I think this should be queued for stable as well.
Applied and queued up for -stable.
Thanks for following up on this Michael.
prev parent reply other threads:[~2019-02-27 17:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 8:58 [PATCH net] bnxt_en: Drop oversize TX packets to prevent errors Michael Chan
2019-02-27 17:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227.093021.1467529615785669970.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).