From: David Miller <davem@davemloft.net>
To: andriy.shevchenko@linux.intel.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v1] net: dev: Use unsigned integer as an argument to left-shift
Date: Wed, 27 Feb 2019 09:34:52 -0800 (PST) [thread overview]
Message-ID: <20190227.093452.479784888345024964.davem@davemloft.net> (raw)
In-Reply-To: <20190227103726.15163-1-andriy.shevchenko@linux.intel.com>
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Wed, 27 Feb 2019 13:37:26 +0300
> 1 << 31 is Undefined Behaviour according to the C standard.
> Use U type modifier to avoid theoretical overflow.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied, thanks Andy.
prev parent reply other threads:[~2019-02-27 17:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 10:37 [PATCH v1] net: dev: Use unsigned integer as an argument to left-shift Andy Shevchenko
2019-02-27 17:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227.093452.479784888345024964.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).