* [PATCH][net-next] ethtool: Use explicit designated initializers for .cmd
@ 2019-02-27 12:47 Li RongQing
2019-02-27 13:51 ` Michal Kubecek
2019-02-27 18:08 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Li RongQing @ 2019-02-27 12:47 UTC (permalink / raw)
To: netdev
Initialize the .cmd member by using a designated struct
initializer. This fixes warning of missing field initializers,
and makes code a little easier to read.
Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
net/core/ethtool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index 47558ffae423..d4918ffddda8 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -1717,7 +1717,7 @@ static noinline_for_stack int ethtool_set_channels(struct net_device *dev,
static int ethtool_get_pauseparam(struct net_device *dev, void __user *useraddr)
{
- struct ethtool_pauseparam pauseparam = { ETHTOOL_GPAUSEPARAM };
+ struct ethtool_pauseparam pauseparam = { .cmd = ETHTOOL_GPAUSEPARAM };
if (!dev->ethtool_ops->get_pauseparam)
return -EOPNOTSUPP;
@@ -2503,7 +2503,7 @@ static int set_phy_tunable(struct net_device *dev, void __user *useraddr)
static int ethtool_get_fecparam(struct net_device *dev, void __user *useraddr)
{
- struct ethtool_fecparam fecparam = { ETHTOOL_GFECPARAM };
+ struct ethtool_fecparam fecparam = { .cmd = ETHTOOL_GFECPARAM };
int rc;
if (!dev->ethtool_ops->get_fecparam)
--
2.16.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][net-next] ethtool: Use explicit designated initializers for .cmd
2019-02-27 12:47 [PATCH][net-next] ethtool: Use explicit designated initializers for .cmd Li RongQing
@ 2019-02-27 13:51 ` Michal Kubecek
2019-02-27 18:08 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Michal Kubecek @ 2019-02-27 13:51 UTC (permalink / raw)
To: Li RongQing; +Cc: netdev
On Wed, Feb 27, 2019 at 08:47:57PM +0800, Li RongQing wrote:
> Initialize the .cmd member by using a designated struct
> initializer. This fixes warning of missing field initializers,
> and makes code a little easier to read.
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
> ---
> net/core/ethtool.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
> index 47558ffae423..d4918ffddda8 100644
> --- a/net/core/ethtool.c
> +++ b/net/core/ethtool.c
> @@ -1717,7 +1717,7 @@ static noinline_for_stack int ethtool_set_channels(struct net_device *dev,
>
> static int ethtool_get_pauseparam(struct net_device *dev, void __user *useraddr)
> {
> - struct ethtool_pauseparam pauseparam = { ETHTOOL_GPAUSEPARAM };
> + struct ethtool_pauseparam pauseparam = { .cmd = ETHTOOL_GPAUSEPARAM };
>
> if (!dev->ethtool_ops->get_pauseparam)
> return -EOPNOTSUPP;
> @@ -2503,7 +2503,7 @@ static int set_phy_tunable(struct net_device *dev, void __user *useraddr)
>
> static int ethtool_get_fecparam(struct net_device *dev, void __user *useraddr)
> {
> - struct ethtool_fecparam fecparam = { ETHTOOL_GFECPARAM };
> + struct ethtool_fecparam fecparam = { .cmd = ETHTOOL_GFECPARAM };
> int rc;
>
> if (!dev->ethtool_ops->get_fecparam)
> --
> 2.16.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][net-next] ethtool: Use explicit designated initializers for .cmd
2019-02-27 12:47 [PATCH][net-next] ethtool: Use explicit designated initializers for .cmd Li RongQing
2019-02-27 13:51 ` Michal Kubecek
@ 2019-02-27 18:08 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-02-27 18:08 UTC (permalink / raw)
To: lirongqing; +Cc: netdev
From: Li RongQing <lirongqing@baidu.com>
Date: Wed, 27 Feb 2019 20:47:57 +0800
> Initialize the .cmd member by using a designated struct
> initializer. This fixes warning of missing field initializers,
> and makes code a little easier to read.
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-27 18:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-27 12:47 [PATCH][net-next] ethtool: Use explicit designated initializers for .cmd Li RongQing
2019-02-27 13:51 ` Michal Kubecek
2019-02-27 18:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).