From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 403BAC43381 for ; Wed, 27 Feb 2019 18:12:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F50020C01 for ; Wed, 27 Feb 2019 18:12:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727488AbfB0SMy (ORCPT ); Wed, 27 Feb 2019 13:12:54 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:46286 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726389AbfB0SMy (ORCPT ); Wed, 27 Feb 2019 13:12:54 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 96FB11411B43B; Wed, 27 Feb 2019 10:12:53 -0800 (PST) Date: Wed, 27 Feb 2019 10:12:53 -0800 (PST) Message-Id: <20190227.101253.34089068957363096.davem@davemloft.net> To: vladbu@mellanox.com Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us Subject: Re: [PATCH net-next] Revert "net: sched: route: don't set arg->stop in route4_walk() when empty" From: David Miller In-Reply-To: <20190227134859.18424-1-vladbu@mellanox.com> References: <20190227134859.18424-1-vladbu@mellanox.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 27 Feb 2019 10:12:53 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vlad Buslov Date: Wed, 27 Feb 2019 15:48:59 +0200 > This reverts commit 3027ff41f67c ("net: sched: route: don't set arg->stop > in route4_walk() when empty") > > Cls API function tcf_proto_is_empty() was changed in commit > 6676d5e416ee ("net: sched: set dedicated tcf_walker flag when tp is empty") > to no longer depend on arg->stop to determine that classifier instance is > empty. Instead, it adds dedicated arg->nonempty field, which makes the fix > in route classifier no longer necessary. > > Signed-off-by: Vlad Buslov Looks good, applied, thanks Vlad.